8300099: Configuration fails to auto-detect build user through $USER in dockers

[DamonFool]

Hi all,

Configuration is broken in dockers after JDK-8296478.
This is because $USER is not defined in dockers [1].

The fix will check whoami if we get an empty $USERNAME.

Thanks.
Best regards,
Jie

[1] https://stackoverflow.com/questions/54411218/docker-why-isnt-user-environment-variable-set

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300099: Configuration fails to auto-detect build user through $USER in dockers

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11983/head:pull/11983
$ git checkout pull/11983

Update a local copy of the PR:
$ git checkout pull/11983
$ git pull https://git.openjdk.org/jdk pull/11983/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11983

View PR using the GUI difftool:
$ git pr show -t 11983

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11983.diff

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (afeff39d)

[shipilev]

I am seeing a relevant failure on some of my Windows machines that run buildbot in "anonymous" shells. whoami exists there, so this PR should fix that trouble.

[magicus]

What happens if you don't have whoami or if you have it and that fails as well?

Hm. Looking at the code, it seems that UTIL_CHECK_STRING_NON_EMPTY should catch that. Can you verify that this is indeed the case? To be clear: If you are missing both $USER and whoami, and are not explicitly setting a user name, configure should fail. But if you are missing this and are using --with-build-user, then it succeeds.

[magicus]

The code changes itself look good.

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300099: Configuration fails to auto-detect build user through $USER in dockers

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• e7fa150: 8299032: Interface IN_NATIVE oop stores for C2
• c250222: 8300110: Unproblemlist Fuzz.java from ProblemList-zgc.txt
• ac63f5f: 8297877: Risk for uninitialized memory in case of CHECK macro early return as part of field access
• be8e6d0: 8299957: Enhance error logging in instrument coding with additional jplis_assert_msg
• 640eff6: 8300040: TypeOopPtr::make_from_klass_common calls itself with args in wrong order
• 19628e3: 8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonFool]

To be clear: If you are missing both $USER and whoami, and are not explicitly setting a user name, configure should fail. But if you are missing this and are using --with-build-user, then it succeeds.

Yes, it behaves like this.
I verified it in our dockers.

Thanks @magicus for your review.

[magicus]

Great, thank you for confirming!

[DamonFool]

/integrate

[openjdk]

Going to push as commit 3ffc955.
Since your change was applied there have been 6 commits pushed to the master branch:

• e7fa150: 8299032: Interface IN_NATIVE oop stores for C2
• c250222: 8300110: Unproblemlist Fuzz.java from ProblemList-zgc.txt
• ac63f5f: 8297877: Risk for uninitialized memory in case of CHECK macro early return as part of field access
• be8e6d0: 8299957: Enhance error logging in instrument coding with additional jplis_assert_msg
• 640eff6: 8300040: TypeOopPtr::make_from_klass_common calls itself with args in wrong order
• 19628e3: 8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool Pushed as commit 3ffc955.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[TheShermanTanker]

Ah, the same issue I was facing with the Actions Workflow. In retrospect I probably should have also done this alongside the shell changes I made in that other PR :/