Skip to content

8278349: JarSigner javadoc example uses SHA-1 #11992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

eirbjo
Copy link
Contributor

@eirbjo eirbjo commented Jan 13, 2023

Please review this trivial PR which updates javadoc sample code in jdk.security.jarsigner.JarSigner to use SHA-256, SHA256withRSA instead of the now considered weak algorithms SHA-1, SHA1withDSA.

The sample code is also updated to use the new snippet syntax.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11992/head:pull/11992
$ git checkout pull/11992

Update a local copy of the PR:
$ git checkout pull/11992
$ git pull https://git.openjdk.org/jdk pull/11992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11992

View PR using the GUI difftool:
$ git pr show -t 11992

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11992.diff

…adoc with SHA-256 and SHA256withRSA. Update to use @snippet syntax.
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2023

👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@eirbjo The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jan 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@eirbjo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278349: JarSigner javadoc example uses SHA-1

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • d117979: 8300054: Use static_assert in basic_types_init

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 13, 2023
@wangweij
Copy link
Contributor

@eirbjo, you can now type /integrate and I'll type /sponsor. Thanks for the fix!

@eirbjo
Copy link
Contributor Author

eirbjo commented Jan 13, 2023

/integrate

@wangweij
Copy link
Contributor

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@eirbjo
Your change (at version 56079e3) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

Going to push as commit 4ec3659.
Since your change was applied there has been 1 commit pushed to the master branch:

  • d117979: 8300054: Use static_assert in basic_types_init

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 13, 2023
@openjdk openjdk bot closed this Jan 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@wangweij @eirbjo Pushed as commit 4ec3659.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@eirbjo eirbjo deleted the jarsigner-sha1 branch January 14, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants