-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8278349: JarSigner javadoc example uses SHA-1 #11992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…adoc with SHA-256 and SHA256withRSA. Update to use @snippet syntax.
👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into |
Webrevs
|
@eirbjo This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@eirbjo, you can now type |
/integrate |
/sponsor |
Please review this trivial PR which updates javadoc sample code in jdk.security.jarsigner.JarSigner to use SHA-256, SHA256withRSA instead of the now considered weak algorithms SHA-1, SHA1withDSA.
The sample code is also updated to use the new snippet syntax.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11992/head:pull/11992
$ git checkout pull/11992
Update a local copy of the PR:
$ git checkout pull/11992
$ git pull https://git.openjdk.org/jdk pull/11992/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11992
View PR using the GUI difftool:
$ git pr show -t 11992
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11992.diff