New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253030: ZGC: Change ZMarkCompleteTimeout unit to microseconds #120
Conversation
|
@pliden The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
/cc hotspot-gc |
@pliden |
/cc remove hotspot |
@pliden |
Change looks good. But I wonder, why choose microseconds as the units? That seems to be almost never used in HotSpot.
@pliden This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 19 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
|
@kimbarrett Thanks for reviewing. I used micros because it seems like the natural unit to use here. Using nanos seems a bit overkill, as we will never need that precision and it would just add a bunch of zeros to the constant, which I'm not sure would help readability. What unit did you have in mind? |
Mailing list message from Kim Barrett on hotspot-gc-dev:
Nanos would have been my choice, since that's widely used. The configuration I?ll go click the reviewed button now. |
/integrate |
@pliden Since your change was applied there have been 19 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 07da3a1. |
The ZMarkCompleteTimeout is currently specified in milliseconds, and its value is 1 (i.e. as low as it can be). In preparation for using a lower time out value than 1ms we should change the ZMarkCompleteTimeout unit to be microseconds, instead of milliseconds.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/120/head:pull/120
$ git checkout pull/120