8300169: Build failure with clang-15 #12005

DamonFool · 2023-01-14T14:28:32Z

Hi all,

Please review the fix for the build failure with clang-15.

-Wbitwise-instead-of-logical

   1) src/hotspot/share/oops/generateOopMap.cpp          <--- fixed the warning
   2) src/hotspot/share/runtime/notificationThread.cpp   <--- keep the code and disable warnings
   3) src/hotspot/share/runtime/serviceThread.cpp        <--- keep the code and disable warnings

-Wdeprecated-non-prototype (all the warnings are disabled)

   1) Mainly caused by files under `src/java.base/share/native/libzip/zlib/`  <--- keep the code and disable warnings
      It occurred while building LIBJLI, LIBZIP and LIBSPLASHSCREEN.

   2) While compiling src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c  <--- keep the code and disable warnings

   3) Caused by src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m  <--- fixed the warnings

-Wdeprecated-builtins

   Caused by files under src/java.desktop/share/native/libharfbuzz/  <--- fixed the warnings

Ref: https://github.com/harfbuzz/harfbuzz/blob/main/src/hb-meta.hh#L202

-Wgnu-folding-constant

   Caused by src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderer.m  <--- keep the code and disable warnings

Thanks.
Best regards,
Jie

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8300169: Build failure with clang-15

Reviewers

David Holmes (@dholmes-ora - Reviewer)
Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12005/head:pull/12005
$ git checkout pull/12005

Update a local copy of the PR:
$ git checkout pull/12005
$ git pull https://git.openjdk.org/jdk pull/12005/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12005

View PR using the GUI difftool:
$ git pr show -t 12005

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12005.diff

bridgekeeper · 2023-01-14T14:29:41Z

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-01-14T14:31:47Z

@DamonFool The following labels will be automatically applied to this pull request:

build
client
core-libs
hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-01-14T14:35:00Z

Webrevs

00: Full (19d7fabb)

kevinrushforth · 2023-01-14T15:03:42Z

src/java.desktop/share/native/libharfbuzz/hb-meta.hh

@@ -188,7 +188,7 @@ template <> struct hb_int_max<signed long long>         : hb_integral_constant<s
 template <> struct hb_int_max<unsigned long long>       : hb_integral_constant<unsigned long long,      ULLONG_MAX>     {};
 #define hb_int_max(T) hb_int_max<T>::value

-#if defined(__GNUC__) && __GNUC__ < 5
+#if defined(__GNUC__) && __GNUC__ < 5 && !defined(__clang__)


Normally, such changes in third-party libraries need to be done upstream, and not locally. @prrace can confirm.

Normally, such changes in third-party libraries need to be done upstream, and not locally. @prrace can confirm.

Thanks @kevinrushforth for your review.

Yes, it had been fixed in the upstream and I just follow it.
Please see https://github.com/harfbuzz/harfbuzz/blob/main/src/hb-meta.hh#L202 .

Or did you mean we had to sync the whole harfbuzz with the upstream?
If so, I would suggest doing it in a separate PR.
What do you think?
Thanks.

No, I didn't mean to update all of harfbuzz. What you've done seems fine to me, but let's see what @prrace says.

If the exact same change has been committed upstream then we are OK to take this because then when we upgrade harfbuzz (under a separate bug) whoever doing the upgrade can be blissfully ignorant of this. In fact it is because there is no easy way to be track changes on the JDK side and reapply them that we have this rule.

AlanBateman · 2023-01-16T08:21:47Z

It occurred while building LIBJLI, LIBZIP and LIBSPLASHSCREEN.

Is there a list of the issues building libjli? I don't see the in the PR or the JBS issue. For the libzip issues, are these in the native methods or when compiling the zlib code, just wondering if there are bug reports for upstream there too.

DamonFool · 2023-01-16T08:51:34Z

Is there a list of the issues building libjli? I don't see the in the PR or the JBS issue. For the libzip issues, are these in the native methods or when compiling the zlib code, just wondering if there are bug reports for upstream there too.

Thanks @AlanBateman for the review.

Here is the bug report while building libjli (target support_native_java.base_libjli_zadler32.o).

1 error generated.
* For target support_native_java.base_libjli_zadler32.o:
/Users/jiefu/jdk/src/java.base/share/native/libzip/zlib/zadler32.c:87:15: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
uLong ZEXPORT adler32_z(adler, buf, len)
              ^
/Users/jiefu/jdk/src/java.base/share/native/libzip/zlib/zadler32.c:158:15: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
uLong ZEXPORT adler32(adler, buf, len)
              ^
/Users/jiefu/jdk/src/java.base/share/native/libzip/zlib/zadler32.c:167:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
local uLong adler32_combine_(adler1, adler2, len2)
            ^
/Users/jiefu/jdk/src/java.base/share/native/libzip/zlib/zadler32.c:167:13: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
/Users/jiefu/jdk/src/java.base/share/native/libzip/zlib/zadler32.c:196:15: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
uLong ZEXPORT adler32_combine(adler1, adler2, len2)
              ^
/Users/jiefu/jdk/src/java.base/share/native/libzip/zlib/zadler32.c:204:15: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
uLong ZEXPORT adler32_combine64(adler1, adler2, len2)
   ... (rest of output omitted)

DamonFool · 2023-01-16T08:56:13Z

For the libzip issues, are these in the native methods or when compiling the zlib code, just wondering if there are bug reports for upstream there too.

Mainly caused by files under src/java.base/share/native/libzip/zlib/.
I'm not sure if there is already a bug report to the upstream.

AlanBateman · 2023-01-16T09:03:19Z

Mainly caused by files under src/java.base/share/native/libzip/zlib/. I'm not sure if there is already a bug report to the upstream.

Maybe this one:
madler/zlib#633

dholmes-ora

Hotspot changes are good.

Thanks.

openjdk · 2023-01-17T04:31:31Z

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300169: Build failure with clang-15

Reviewed-by: dholmes, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

8c12ae8: 8283203: Fix typo in SystemTray.getTrayIconSize javadoc
e7e3712: 8300010: UnsatisfiedLinkError on calling System.console().readPassword() on Windows
0b9ff06: 8300184: Optimize ResourceHashtableBase::iterate_all using _number_of_entries
75b122f: 8300120: Configure should support different defaults for CI/dev build environments
e139ec3: 8300069: Left shift of negative value in share/adlc/dict2.cpp
fb147aa: 8300228: ModuleReader.find on exploded module throws if resource name maps to invalid file path
4cd166f: 8300125: Serial: Remove unused Generation::reset_saved_marks
85d70ac: Merge
e15bdc5: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
b7fb8ef: 8299323: Allow extended registers for cmpw
... and 29 more: https://git.openjdk.org/jdk/compare/4be94e435002d9d6cb594a393e9e35d650a9a0c9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

DamonFool · 2023-01-17T06:00:33Z

Hotspot changes are good.

Thanks @dholmes-ora .

DamonFool · 2023-01-17T11:30:02Z

Hi @kevinrushforth and @AlanBateman , are you fine with this change?
Thanks.

kevinrushforth · 2023-01-17T13:33:06Z

Yes, but I would wait for @prrace to review the Harfbuzz change.

AlanBateman · 2023-01-17T16:51:14Z

Hi @kevinrushforth and @AlanBateman , are you fine with this change?

No objection from me but I agree with Kevin to wait to see what Phil says about Harfbuzz.

prrace

client changes are OK by me.

mlbridge · 2023-01-17T18:54:23Z

Mailing list message from Patrick Chen on build-dev:

no you have to revert the commit

Le mar. 17 janv. 2023 ? 17:55, Alan Bateman <alanb at openjdk.org> a ?crit :

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/build-dev/attachments/20230117/4dc50b9b/attachment.htm>

DamonFool · 2023-01-17T23:52:58Z

Mailing list message from Patrick Chen on build-dev:

no you have to revert the commit

Why?
Is there anything wrong?
Thanks.

Le mar. 17 janv. 2023 ? 17:55, Alan Bateman a ?crit :

-------------- next part -------------- An HTML attachment was scrubbed... URL: https://mail.openjdk.org/pipermail/build-dev/attachments/20230117/4dc50b9b/attachment.htm

DamonFool · 2023-01-17T23:54:16Z

client changes are OK by me.

Thanks @prrace .

DamonFool · 2023-01-18T10:30:47Z

/integrate

openjdk · 2023-01-18T10:32:13Z

Going to push as commit 15a9186.
Since your change was applied there have been 53 commits pushed to the master branch:

d918042: 8300267: Remove duplicated setter/getter for do_not_unlock
7c8b99e: 8300117: Replace use of JNI_COMMIT mode with mode 0
c705673: 8299089: Instrument global jni handles with tag to make them distinguishable
66f7387: 8299074: nmethod marked for deoptimization is not deoptimized
1f438a8: 8282651: ZGC: vmTestbase/gc/ArrayJuggle/ tests fails intermittently with exit code 97
f1194dc: 8300109: RISC-V: Improve code generation for MinI/MaxI nodes
89a032d: 8300002: Performance regression caused by non-inlined hot methods due to post call noop instructions
7071397: 8299224: TestReporterStreams.java has bad indentation for legal header
1d8b87d: 8300321: Use link tags in javax.sql.rowset package-info
f9883fc: 8300279: Use generalized see and link tags in core libs in client libs
... and 43 more: https://git.openjdk.org/jdk/compare/4be94e435002d9d6cb594a393e9e35d650a9a0c9...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-01-18T10:32:30Z

@DamonFool Pushed as commit 15a9186.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8300169: Build failure with clang-15

19d7fab

openjdk bot added the rfr Pull request is ready for review label Jan 14, 2023

openjdk bot added build build-dev@openjdk.org hotspot hotspot-dev@openjdk.org client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jan 14, 2023

kevinrushforth reviewed Jan 14, 2023

View reviewed changes

dholmes-ora approved these changes Jan 17, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 17, 2023

prrace approved these changes Jan 17, 2023

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jan 18, 2023

openjdk bot closed this Jan 18, 2023

openjdk bot removed the ready Pull request is ready to be integrated label Jan 18, 2023

openjdk bot removed the rfr Pull request is ready for review label Jan 18, 2023

DamonFool deleted the JDK-8300169 branch January 18, 2023 10:35

jiekang mentioned this pull request Dec 7, 2023

MacOS: Harfbuzz throws 70+ megabytes of deprecation warnings during build adoptium/temurin-build#3562

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8300169: Build failure with clang-15 #12005

8300169: Build failure with clang-15 #12005

DamonFool commented Jan 14, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jan 14, 2023

openjdk bot commented Jan 14, 2023

mlbridge bot commented Jan 14, 2023

kevinrushforth Jan 14, 2023

DamonFool Jan 15, 2023

kevinrushforth Jan 17, 2023

prrace Jan 17, 2023

AlanBateman commented Jan 16, 2023

DamonFool commented Jan 16, 2023

DamonFool commented Jan 16, 2023

AlanBateman commented Jan 16, 2023

dholmes-ora left a comment

openjdk bot commented Jan 17, 2023 •

edited

Loading

DamonFool commented Jan 17, 2023

DamonFool commented Jan 17, 2023

kevinrushforth commented Jan 17, 2023

AlanBateman commented Jan 17, 2023

prrace left a comment

mlbridge bot commented Jan 17, 2023

DamonFool commented Jan 17, 2023

DamonFool commented Jan 17, 2023

DamonFool commented Jan 18, 2023

openjdk bot commented Jan 18, 2023

openjdk bot commented Jan 18, 2023

8300169: Build failure with clang-15 #12005

8300169: Build failure with clang-15 #12005

Conversation

DamonFool commented Jan 14, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jan 14, 2023

openjdk bot commented Jan 14, 2023

mlbridge bot commented Jan 14, 2023

Webrevs

kevinrushforth Jan 14, 2023

Choose a reason for hiding this comment

DamonFool Jan 15, 2023

Choose a reason for hiding this comment

kevinrushforth Jan 17, 2023

Choose a reason for hiding this comment

prrace Jan 17, 2023

Choose a reason for hiding this comment

AlanBateman commented Jan 16, 2023

DamonFool commented Jan 16, 2023

DamonFool commented Jan 16, 2023

AlanBateman commented Jan 16, 2023

dholmes-ora left a comment

Choose a reason for hiding this comment

openjdk bot commented Jan 17, 2023 • edited Loading

DamonFool commented Jan 17, 2023

DamonFool commented Jan 17, 2023

kevinrushforth commented Jan 17, 2023

AlanBateman commented Jan 17, 2023

prrace left a comment

Choose a reason for hiding this comment

mlbridge bot commented Jan 17, 2023

DamonFool commented Jan 17, 2023

DamonFool commented Jan 17, 2023

DamonFool commented Jan 18, 2023

openjdk bot commented Jan 18, 2023

openjdk bot commented Jan 18, 2023

DamonFool commented Jan 14, 2023 •

edited by openjdk bot

Loading

openjdk bot commented Jan 17, 2023 •

edited

Loading