8299213: Bad cast in GrowableArrayWithAllocator<>::grow

[afshin-zafari]

Description

The grow size was wrongfully casted from int to uint32.

Patch

The casting is removed.

Tests

Local: gtest:GrowableArrays*
mach5 tier1-5

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299213: Bad cast in GrowableArrayWithAllocator<>::grow

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Johan Sjölen (@jdksjolen - Committer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12007/head:pull/12007
$ git checkout pull/12007

Update a local copy of the PR:
$ git checkout pull/12007
$ git pull https://git.openjdk.org/jdk pull/12007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12007

View PR using the GUI difftool:
$ git pr show -t 12007

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12007.diff

[bridgekeeper]

👋 Welcome back afshin-zafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@afshin-zafari The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (70e3dd59)

[jdksjolen]

// precondition: if signed, value >= 0.
// precondition: value < maximum power of two representable by T.
template <typename T, ENABLE_IF(std::is_integral<T>::value)>
inline T next_power_of_2(T value)  {

So this should require an assert that j >= 0.

[jdksjolen]

/reviewer credit @jdksjolen

[openjdk]

@jdksjolen Only the author (@afshin-zafari) is allowed to issue the reviewer command.

[kimbarrett]

// precondition: if signed, value >= 0.
// precondition: value < maximum power of two representable by T.
template <typename T, ENABLE_IF(std::is_integral<T>::value)>
inline T next_power_of_2(T value)  {

So this should require an assert that j >= 0.

next_power_of_2 already has that as a precondition that the argument is >= 0 if signed. And it's (indirectly) asserted.

[kimbarrett]

Looks good.

[openjdk]

@afshin-zafari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299213: Bad cast in GrowableArrayWithAllocator<>::grow

Reviewed-by: kbarrett, jsjolen, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• 859ccd1: 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes
• 240830d: 8297092: [macos_aarch64] Add support for SHA feature detection
• f52f6e6: 8299972: Remove metaprogramming/removeReference.hpp
• 4c1e66e: 8299971: Remove metaprogramming/conditional.hpp
• 4073b68: 8298047: Remove all non-significant trailing whitespace from properties files
• 506c818: 8296401: ConcurrentHashTable::bulk_delete might miss to delete some objects
• 319de6a: 8300124: Remove unnecessary assert in GenCollectedHeap::initialize
• 289aed4: 8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug
• a2f6766: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines
• a734285: 8299879: CollectedHeap hierarchy should use override
• ... and 28 more: https://git.openjdk.org/jdk/compare/be8e6d05db2f623626506e64a2fb7caf755d5d06...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kimbarrett, @jdksjolen, @TheShermanTanker) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[afshin-zafari]

/integrate

[openjdk]

@afshin-zafari
Your change (at version 70e3dd5) is now ready to be sponsored by a Committer.

[jdksjolen]

Aha, it's asserted in the next call.

LGTM then.

[TheShermanTanker]

Looks Good, though you should be careful to only issue /integrate when you have at least 2 reviews if your change happens to be on the JVM itself (I learnt that the hard way)

[dholmes-ora]

/sponsor

[openjdk]

Going to push as commit 6a81d52.
Since your change was applied there have been 41 commits pushed to the master branch:

• 8365c67: 8300084: AquaFileChooserUI.getDefaultButton returns null
• 382fe51: 8163229: several regression tests have a main method that is never executed
• 06f9374: 8298867: Basics.java fails with SSL handshake exception
• 859ccd1: 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes
• 240830d: 8297092: [macos_aarch64] Add support for SHA feature detection
• f52f6e6: 8299972: Remove metaprogramming/removeReference.hpp
• 4c1e66e: 8299971: Remove metaprogramming/conditional.hpp
• 4073b68: 8298047: Remove all non-significant trailing whitespace from properties files
• 506c818: 8296401: ConcurrentHashTable::bulk_delete might miss to delete some objects
• 319de6a: 8300124: Remove unnecessary assert in GenCollectedHeap::initialize
• ... and 31 more: https://git.openjdk.org/jdk/compare/be8e6d05db2f623626506e64a2fb7caf755d5d06...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora @afshin-zafari Pushed as commit 6a81d52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.