JDK-8300222: Replace NULL with nullptr in share/logging #12014
Conversation
|
👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into |
|
@jdksjolen The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
jdksjolen
changed the title
| char buffer[1024]; | ||
| if (os::get_host_name(buffer, sizeof(buffer))) { | ||
| host_name = os::strdup_check_oom(buffer); | ||
| const char* old_value = Atomic::cmpxchg(&_host_name, (const char*)NULL, host_name); | ||
| if (old_value != NULL) { | ||
| const char* old_value = Atomic::cmpxchg(&_host_name, (const char*)nullptr, host_name); |
There was a problem hiding this comment.
I wonder if you need this cast with nullptr ?
There was a problem hiding this comment.
The nullptr argument is templated, so we do need the cast.
There was a problem hiding this comment.
Thanks for checking. I won't ask on the next one. :)
There was a problem hiding this comment.
I'd like to add overloads for std::nullptr_t someday.
|
@jdksjolen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 240 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
| @@ -192,10 +192,10 @@ void AsyncLogWriter::initialize() { | |||
| AsyncLogWriter* self = new AsyncLogWriter(); | |||
| if (self->_initialized) { | |||
| Atomic::release_store_fence(&AsyncLogWriter::_instance, self); | |||
| // All readers of _instance after the fence see non-NULL. | |||
| // All readers of _instance after the fence see non-nullptr. | |||
There was a problem hiding this comment.
Nit: When "null" or "NULL" are used in prose there is some ambiguity about whether it is referring to the general concept of nullness or the value NULL. In this case I would have written this as "see non-null". I find "non-nullptr" a bit jarring.
|
/integrate The tier1 tests are passing, so I'm integrating this. Thank you for the reviews. |
|
Going to push as commit bd5ca95.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@jdksjolen Pushed as commit bd5ca95. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Do the conversion in the share/logging sub-directory and all of its files.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12014/head:pull/12014$ git checkout pull/12014Update a local copy of the PR:
$ git checkout pull/12014$ git pull https://git.openjdk.org/jdk pull/12014/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12014View PR using the GUI difftool:
$ git pr show -t 12014Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12014.diff