8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu

[SWinxy]

Please review this small change to cache a component's popup menu in BLAF.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu

Reviewers

• Prasanta Sadhukhan (@prsadhuk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12017/head:pull/12017
$ git checkout pull/12017

Update a local copy of the PR:
$ git checkout pull/12017
$ git pull https://git.openjdk.org/jdk pull/12017/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12017

View PR using the GUI difftool:
$ git pr show -t 12017

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12017.diff

[bridgekeeper]

👋 Welcome back SWinxy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SWinxy The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (0abf6066)
• 01: Full - Incremental (37746f07)
• 00: Full (a17c4cdb)

[aivanov-jdk]

Please change your IDE settings to arrange imports in the following order:

import java.*;

import javax.*;

import com.*; // Other packages

In JDK code, its packages are a priority whereas sun.*, com.* and others are internal packages.

[openjdk]

@SWinxy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 73 new commits pushed to the master branch:

• 24cdcd4: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview)
• 8e3036c: 8300595: Use improved @see and @link syntax in javax.lang.model and javax.tools
• 715b509: 8298632: [TESTBUG] Add IR checks in jtreg vectorization tests
• 910dffe: 8292635: Run ArchivedEnumTest.java in jdk tier testing
• fc9f8ba: Merge
• b9275a8: 8300275: SegmentScope.isAccessibleBy returning incorrect values
• c1b4212: 8300195: Fall-through issue occurs when using record pattern in switch statements
• 0f925fe: 8295723: security/infra/wycheproof/RunWycheproof.java fails with Assertion Error
• bd324ce: 8295687: Better BMP bounds
• 93161e4: 8293742: Better Banking of Sounds
• ... and 63 more: https://git.openjdk.org/jdk/compare/f52f6e65fba0360d3cf114e19fea402ab0d65eba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @prsadhuk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[SWinxy]

/integrate

Thank you thank you, Prasanta.

[openjdk]

@SWinxy
Your change (at version 0abf606) is now ready to be sponsored by a Committer.

[SWinxy]

@TheShermanTanker you might be needed here!

[TheShermanTanker]

/sponsor

[TheShermanTanker]

Good Work buddy :)

[openjdk]

Going to push as commit 2e9cb4b.
Since your change was applied there have been 74 commits pushed to the master branch:

• 7348b9e: 8300167: Add validation of the raster's layout before using in native
• 24cdcd4: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview)
• 8e3036c: 8300595: Use improved @see and @link syntax in javax.lang.model and javax.tools
• 715b509: 8298632: [TESTBUG] Add IR checks in jtreg vectorization tests
• 910dffe: 8292635: Run ArchivedEnumTest.java in jdk tier testing
• fc9f8ba: Merge
• b9275a8: 8300275: SegmentScope.isAccessibleBy returning incorrect values
• c1b4212: 8300195: Fall-through issue occurs when using record pattern in switch statements
• 0f925fe: 8295723: security/infra/wycheproof/RunWycheproof.java fails with Assertion Error
• bd324ce: 8295687: Better BMP bounds
• ... and 64 more: https://git.openjdk.org/jdk/compare/f52f6e65fba0360d3cf114e19fea402ab0d65eba...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker @SWinxy Pushed as commit 2e9cb4b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.