8301822: BasicLookAndFeel does not need to check for null after checking for type

[SWinxy]

BasicLookAndFeel checks an instanceof in its AWTEventHelper listener class, but the result of that will always be non-null. The check should be removed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301822: BasicLookAndFeel does not need to check for null after checking for type

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12019/head:pull/12019
$ git checkout pull/12019

Update a local copy of the PR:
$ git checkout pull/12019
$ git pull https://git.openjdk.org/jdk pull/12019/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12019

View PR using the GUI difftool:
$ git pr show -t 12019

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12019.diff

[bridgekeeper]

👋 Welcome back SWinxy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SWinxy The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mrserb]

Looks fine.

[TheShermanTanker]

https://bugs.openjdk.org/browse/JDK-8301822

[mlbridge]

Webrevs

• 00: Full (235017cb)

[openjdk]

@SWinxy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301822: BasicLookAndFeel does not need to check for null after checking for type

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 427 new commits pushed to the master branch:

• 3b05a94: 8301858: Verification error when compiling switch with record patterns
• e4d1cff: 8300268: ServerImpl allows too many idle connections when using sun.net.httpserver.maxIdleConnections
• af8973d: Merge
• e81f20b: 8301989: new javax.swing.text.DefaultCaret().setBlinkRate(N) results in NPE
• 6f460e4: 8301863: ObjectInputFilter example incorrectly calls rejectUndecidedClass
• 2caa56a: 8301843: Remove dummy region allocation
• d401982: 8302121: Parallel: Remove unused arg in PSCardTable::inline_write_ref_field_gc
• 916374d: 8302067: [AIX] AIX build error on os_aix_ppc.cpp
• a4039e3: 8302043: [AIX] Safefetch fails for bad_addressN and bad_address32
• 04f3018: 8299739: HashedPasswordFileTest.java and ExceptionTest.java can fail with java.lang.NullPointerException
• ... and 417 more: https://git.openjdk.org/jdk/compare/f52f6e65fba0360d3cf114e19fea402ab0d65eba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[SWinxy]

/integrate

[openjdk]

@SWinxy
Your change (at version 235017c) is now ready to be sponsored by a Committer.

[TheShermanTanker]

/sponsor

[openjdk]

Going to push as commit 597a9a4.
Since your change was applied there have been 427 commits pushed to the master branch:

• 3b05a94: 8301858: Verification error when compiling switch with record patterns
• e4d1cff: 8300268: ServerImpl allows too many idle connections when using sun.net.httpserver.maxIdleConnections
• af8973d: Merge
• e81f20b: 8301989: new javax.swing.text.DefaultCaret().setBlinkRate(N) results in NPE
• 6f460e4: 8301863: ObjectInputFilter example incorrectly calls rejectUndecidedClass
• 2caa56a: 8301843: Remove dummy region allocation
• d401982: 8302121: Parallel: Remove unused arg in PSCardTable::inline_write_ref_field_gc
• 916374d: 8302067: [AIX] AIX build error on os_aix_ppc.cpp
• a4039e3: 8302043: [AIX] Safefetch fails for bad_addressN and bad_address32
• 04f3018: 8299739: HashedPasswordFileTest.java and ExceptionTest.java can fail with java.lang.NullPointerException
• ... and 417 more: https://git.openjdk.org/jdk/compare/f52f6e65fba0360d3cf114e19fea402ab0d65eba...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker @SWinxy Pushed as commit 597a9a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.