New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283203: Fix typo in SystemTray.getTrayIconSize javadoc #12020
Conversation
|
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking this one. It looks good to me except for additional words in the description.
Could you also update the copyright year?
I submitted JDK-8300280 regarding “…the size in pixels…”:
|
@SWinxy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.
|
/integrate |
@TheShermanTanker if you're good to sponsor. |
/sponsor |
Going to push as commit 8c12ae8.
Your commit was automatically rebased without conflicts. |
@aivanov-jdk @SWinxy Pushed as commit 8c12ae8. |
Please review this itty-bitty typo fix.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12020/head:pull/12020
$ git checkout pull/12020
Update a local copy of the PR:
$ git checkout pull/12020
$ git pull https://git.openjdk.org/jdk pull/12020/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12020
View PR using the GUI difftool:
$ git pr show -t 12020
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12020.diff