JDK-8300260: Remove metaprogramming/isSame.hpp

[jcking]

Code cleanup of pre-C++11 <type_traits> implementations.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300260: Remove metaprogramming/isSame.hpp

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer) ⚠️ Review applies to 19a991ad
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12040/head:pull/12040
$ git checkout pull/12040

Update a local copy of the PR:
$ git checkout pull/12040
$ git pull https://git.openjdk.org/jdk pull/12040/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12040

View PR using the GUI difftool:
$ git pr show -t 12040

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12040.diff

[bridgekeeper]

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jcking The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full (82ae0293)
• 01: Full - Incremental (19a991ad)
• 00: Full (827f8d81)

[tschatzl]

Lgtm.

[openjdk]

@jcking this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout remove-is-same
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@jcking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300260: Remove metaprogramming/isSame.hpp

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• a6c2a2a: 8300692: GCC 12 reports some compiler warnings in bundled freetype
• bb42e61: 8300493: Use ArraysSupport.vectorizedHashCode in j.u.zip.ZipCoder
• 06394ee: 8300590: [JVMCI] BytecodeFrame.equals is broken
• 5331a3e: 8298908: Instrument Metaspace for ASan
• e1ee672: 8300725: Improve performance of ColorConvertOp for default destinations with alpha
• 7c2f77a: 8300584: Accelerate AVX-512 CRC32C for small buffers
• 5784eb7: 8300721: Cleanup ProblemList-svc-vthread.txt
• 9d44dd0: 8297972: Poly1305 Endianness on ByteBuffer not enforced
• facd415: 8297757: VarHandles.getStaticFieldFromBaseAndOffset should get the receiver type from VarHandle
• e803855: 8299863: URLFromURITest.java should import org.junit.jupiter.api.Test
• ... and 21 more: https://git.openjdk.org/jdk/compare/d85243f02b34d03bd7af63a5bcbc73f500f720df...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jcking]

/integrate

[openjdk]

@jcking
Your change (at version 82ae029) is now ready to be sponsored by a Committer.

[kimbarrett]

Looks good.

[kimbarrett]

/sponsor

[openjdk]

Going to push as commit c8dd758.
Since your change was applied there have been 31 commits pushed to the master branch:

• a6c2a2a: 8300692: GCC 12 reports some compiler warnings in bundled freetype
• bb42e61: 8300493: Use ArraysSupport.vectorizedHashCode in j.u.zip.ZipCoder
• 06394ee: 8300590: [JVMCI] BytecodeFrame.equals is broken
• 5331a3e: 8298908: Instrument Metaspace for ASan
• e1ee672: 8300725: Improve performance of ColorConvertOp for default destinations with alpha
• 7c2f77a: 8300584: Accelerate AVX-512 CRC32C for small buffers
• 5784eb7: 8300721: Cleanup ProblemList-svc-vthread.txt
• 9d44dd0: 8297972: Poly1305 Endianness on ByteBuffer not enforced
• facd415: 8297757: VarHandles.getStaticFieldFromBaseAndOffset should get the receiver type from VarHandle
• e803855: 8299863: URLFromURITest.java should import org.junit.jupiter.api.Test
• ... and 21 more: https://git.openjdk.org/jdk/compare/d85243f02b34d03bd7af63a5bcbc73f500f720df...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett @jcking Pushed as commit c8dd758.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.