JDK-8300264: Remove metaprogramming/isPointer.hpp

[jcking]

Code cleanup of pre-C++11 <type_traits> implementations.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300264: Remove metaprogramming/isPointer.hpp

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12041/head:pull/12041
$ git checkout pull/12041

Update a local copy of the PR:
$ git checkout pull/12041
$ git pull https://git.openjdk.org/jdk pull/12041/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12041

View PR using the GUI difftool:
$ git pr show -t 12041

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12041.diff

[bridgekeeper]

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jcking The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (892a7798)

[kimbarrett]

Looks good.

[kimbarrett]

[pre-existing] The if-body is mis-indented.

[openjdk]

@jcking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300264: Remove metaprogramming/isPointer.hpp

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

• 24cdcd4: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview)
• 8e3036c: 8300595: Use improved @see and @link syntax in javax.lang.model and javax.tools
• 715b509: 8298632: [TESTBUG] Add IR checks in jtreg vectorization tests
• 910dffe: 8292635: Run ArchivedEnumTest.java in jdk tier testing
• fc9f8ba: Merge
• b9275a8: 8300275: SegmentScope.isAccessibleBy returning incorrect values
• c1b4212: 8300195: Fall-through issue occurs when using record pattern in switch statements
• 0f925fe: 8295723: security/infra/wycheproof/RunWycheproof.java fails with Assertion Error
• bd324ce: 8295687: Better BMP bounds
• 93161e4: 8293742: Better Banking of Sounds
• ... and 49 more: https://git.openjdk.org/jdk/compare/85d70acc6e5b9f394d446c270f15bb3793916e63...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kimbarrett, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jcking]

/integrate

[openjdk]

@jcking
Your change (at version 892a779) is now ready to be sponsored by a Committer.

[tschatzl]

/sponsor

[openjdk]

Going to push as commit eba87a0.
Since your change was applied there have been 65 commits pushed to the master branch:

• 08e6218: 8300526: Test runtime/jni/IsVirtualThread/IsVirtualThread.java should exercise alternative virtual thread implementation
• cfe5746: 8300242: Replace NULL with nullptr in share/code/
• 5f66024: 8299959: C2: CmpU::Value must filter overflow computation against local sub computation
• 5b0af1a: 8208077: File.listRoots performance degradation
• 2e9cb4b: 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu
• 7348b9e: 8300167: Add validation of the raster's layout before using in native
• 24cdcd4: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview)
• 8e3036c: 8300595: Use improved @see and @link syntax in javax.lang.model and javax.tools
• 715b509: 8298632: [TESTBUG] Add IR checks in jtreg vectorization tests
• 910dffe: 8292635: Run ArchivedEnumTest.java in jdk tier testing
• ... and 55 more: https://git.openjdk.org/jdk/compare/85d70acc6e5b9f394d446c270f15bb3793916e63...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl @jcking Pushed as commit eba87a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.