8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case

[TejeshR13]

This is a diagnostic update related to JDK-8295804. The issue was not reproducible and was showing up in particular machines (Where the machines are down now). So adding a screen capture to BufferedImage in case of failure so that it will help in analysis when the issue comes up in future.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12060/head:pull/12060
$ git checkout pull/12060

Update a local copy of the PR:
$ git checkout pull/12060
$ git pull https://git.openjdk.org/jdk pull/12060/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12060

View PR using the GUI difftool:
$ git pr show -t 12060

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12060.diff

[bridgekeeper]

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TejeshR13 The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7f369bde)
• 00: Full (89ab2eb8)

[kumarabhi006]

In JDK-8295804, it is mentioned that failure was observed in macOS 13 also.
Did you try to reproduce the issue in macOS 13?

[TejeshR13]

In JDK-8295804, it is mentioned that failure was observed in macOS 13 also. Did you try to reproduce the issue in macOS 13?

Not yet, since any particular host is not mentioned in JBS I will try in random host with 13.0.

[mrserb]

I think what you want to use here is the bounds of the screen, not the size, since the screen coordinates may start from non-zero values.

[TejeshR13]

GraphicsConfiguration gc = GraphicsEnvironment.
                         getLocalGraphicsEnvironment().getDefaultScreenDevice().getDefaultConfiguration();
                Rectangle gcBounds = gc.getBounds();

This way?

[mrserb]

yes.

[TejeshR13]

Updated.

[openjdk]

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 153 new commits pushed to the master branch:

• adcfd25: 8301098: Remove dead code FileMapInfo::stop_sharing_and_unmap()
• 9f0887e: 8296661: Typo Found In CSSParser.java
• ccf2f58: 8300806: Update googletest to v1.13.0
• edf1e1a: 8300592: ASan build does not correctly propagate options to some test launchers
• e80b5ea: 8299635: Hotspot update for deprecated sprintf in Xcode 14
• f279c75: 8300805: Update autoconf build-aux files with latest from 2022-09-17
• a23ff63: 8301086: jdk/internal/util/ByteArray/ReadWriteValues.java fails with CompilationError
• 61775c8: 8300997: Add curl support to createJMHBundle.sh
• 8a47429: 8295944: Move the Http2TestServer and related classes into a package of its own
• c8ad600: 8301004: httpclient: Add more debug to HttpResponseInputStream
• ... and 143 more: https://git.openjdk.org/jdk/compare/f1194dc07ec347f4f9d785e7647983da61441c0e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TejeshR13]

/integrate

[openjdk]

Going to push as commit db8fa1b.
Since your change was applied there have been 189 commits pushed to the master branch:

• 3758487: 8301180: Replace NULL with nullptr in share/gc/parallel/
• d7aa87f: 8300176: URLEncoder/URLDecoder static fields should be private static final
• 107e184: 8301179: Replace NULL with nullptr in share/gc/serial/
• b77abc6: 8301178: Replace NULL with nullptr in share/gc/epsilon/
• f7da09c: 8301164: Remove unused ResourceStack class
• 6e4710b: 8300253: Introduce AArch64 nzcv accessors
• c6b3f2d: 8301129: Link to debuginfo files should only be made after stripping
• 938b409: 8301133: IGV: NPE occurs when creating a diff graph with a graph in a different folder
• 0eb1f66: 8298038: [s390] Configure script detects num_cores +1
• c3ff151: 8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr
• ... and 179 more: https://git.openjdk.org/jdk/compare/f1194dc07ec347f4f9d785e7647983da61441c0e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TejeshR13 Pushed as commit db8fa1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.