8300489: Use ArraysSupport.vectorizedHashCode in j.l.CharacterName

[cl4es]

This patch makes use of ArraysSupport.vectorizedHashCode and helps verify the performance win also for range-based hash calculations. Also modernized and cleaned up the surrounding code somewhat.

Benchmark                          Mode  Cnt    Score   Error  Units
Characters.CodePoints.codePointOf  avgt   15  153.753 ± 6.119  ns/op
Characters.CodePoints.codePointOf  avgt   15  134.753 ± 4.386  ns/op # after, 1.14x

For C1 and C2 on non-x86 platforms the performance is neutral. Interpreter sees a 1-2% regression due a few added calls.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300489: Use ArraysSupport.vectorizedHashCode in j.l.CharacterName

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12068/head:pull/12068
$ git checkout pull/12068

Update a local copy of the PR:
$ git checkout pull/12068
$ git pull https://git.openjdk.org/jdk pull/12068/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12068

View PR using the GUI difftool:
$ git pr show -t 12068

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12068.diff

[bridgekeeper]

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cl4es The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (df21d024)

[openjdk]

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300489: Use ArraysSupport.vectorizedHashCode in j.l.CharacterName

Reviewed-by: alanb, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• fcbf9d0: 8300243: Replace NULL with nullptr in share/compiler/
• c205cae: 8297851: Add devkit for RISC-V
• c3242ee: 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
• b3684f4: 8153837: AArch64: Handle special cases for MaxINode & MinINode
• 754f6e6: 8300237: Minor improvements in MethodHandles
• 85d8bac: 8300166: Unused array allocation in ProcessPath.doProcessPath
• c464ef1: 8292741: Convert JvmtiTagMapTable to ResourceHashtable
• 1aded82: 8300488: Incorrect usage of CATCH_BAD_ALLOC as a macro call
• bd5ca95: 8300222: Replace NULL with nullptr in share/logging
• 15a9186: 8300169: Build failure with clang-15
• ... and 6 more: https://git.openjdk.org/jdk/compare/89a032dc057d04c996632ad317a0303cf3560852...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[cl4es]

Thanks for reviewing!

/integrate

[openjdk]

Going to push as commit 3ea0b8b.
Since your change was applied there have been 16 commits pushed to the master branch:

• fcbf9d0: 8300243: Replace NULL with nullptr in share/compiler/
• c205cae: 8297851: Add devkit for RISC-V
• c3242ee: 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
• b3684f4: 8153837: AArch64: Handle special cases for MaxINode & MinINode
• 754f6e6: 8300237: Minor improvements in MethodHandles
• 85d8bac: 8300166: Unused array allocation in ProcessPath.doProcessPath
• c464ef1: 8292741: Convert JvmtiTagMapTable to ResourceHashtable
• 1aded82: 8300488: Incorrect usage of CATCH_BAD_ALLOC as a macro call
• bd5ca95: 8300222: Replace NULL with nullptr in share/logging
• 15a9186: 8300169: Build failure with clang-15
• ... and 6 more: https://git.openjdk.org/jdk/compare/89a032dc057d04c996632ad317a0303cf3560852...master

Your commit was automatically rebased without conflicts.

[openjdk]

@cl4es Pushed as commit 3ea0b8b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.