Skip to content

8300526: Test runtime/jni/IsVirtualThread/IsVirtualThread.java should exercise alternative virtual thread implementation#12070

Closed
AlanBateman wants to merge 1 commit intoopenjdk:masterfrom
AlanBateman:JDK-8300526
Closed

8300526: Test runtime/jni/IsVirtualThread/IsVirtualThread.java should exercise alternative virtual thread implementation#12070
AlanBateman wants to merge 1 commit intoopenjdk:masterfrom
AlanBateman:JDK-8300526

Conversation

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jan 18, 2023

test/hotspot/jtreg/runtime/jni/IsVirtualThread/IsVirtualThread.java is updated to exercise JNI IsVirtualThread when running with -XX:-VMContinuations. On ports with VMContinuations supported, the test re-runs with the alternative implementation of virtual threads to ensure that the JNI function works as expected.

While in the area, the test is changed to used the jtreg @enablePreview tag and also changed to put a try-finally around the test for a started thread to ensure it doesn't it unparks in the event that the test fails.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300526: Test runtime/jni/IsVirtualThread/IsVirtualThread.java should exercise alternative virtual thread implementation

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12070/head:pull/12070
$ git checkout pull/12070

Update a local copy of the PR:
$ git checkout pull/12070
$ git pull https://git.openjdk.org/jdk pull/12070/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12070

View PR using the GUI difftool:
$ git pr show -t 12070

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12070.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2023

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 18, 2023

@AlanBateman The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 18, 2023
@AlanBateman AlanBateman changed the title 8300526: Test runtime/jni/IsVirtualThread should exercise alternative virtual thread implementation 8300526: Test runtime/jni/IsVirtualThread/IsVirtualThread.java should exercise alternative virtual thread implementation Jan 18, 2023
@AlanBateman AlanBateman marked this pull request as ready for review January 18, 2023 14:28
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 18, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 18, 2023

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300526: Test runtime/jni/IsVirtualThread/IsVirtualThread.java should exercise alternative virtual thread implementation

Reviewed-by: pchilanomate

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 2a46e07: 8286581: Make Java process DPI Aware if sun.java2d.dpiaware property is set
  • 3ea0b8b: 8300489: Use ArraysSupport.vectorizedHashCode in j.l.CharacterName
  • fcbf9d0: 8300243: Replace NULL with nullptr in share/compiler/
  • c205cae: 8297851: Add devkit for RISC-V
  • c3242ee: 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
  • b3684f4: 8153837: AArch64: Handle special cases for MaxINode & MinINode
  • 754f6e6: 8300237: Minor improvements in MethodHandles
  • 85d8bac: 8300166: Unused array allocation in ProcessPath.doProcessPath
  • c464ef1: 8292741: Convert JvmtiTagMapTable to ResourceHashtable

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 18, 2023
@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 19, 2023

Going to push as commit 08e6218.
Since your change was applied there have been 40 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 19, 2023
@openjdk openjdk bot closed this Jan 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@AlanBateman Pushed as commit 08e6218.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants