8300526: Test runtime/jni/IsVirtualThread/IsVirtualThread.java should exercise alternative virtual thread implementation#12070
Conversation
|
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
|
@AlanBateman The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 08e6218.
Your commit was automatically rebased without conflicts. |
|
@AlanBateman Pushed as commit 08e6218. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
test/hotspot/jtreg/runtime/jni/IsVirtualThread/IsVirtualThread.java is updated to exercise JNI IsVirtualThread when running with -XX:-VMContinuations. On ports with VMContinuations supported, the test re-runs with the alternative implementation of virtual threads to ensure that the JNI function works as expected.
While in the area, the test is changed to used the jtreg
@enablePreviewtag and also changed to put a try-finally around the test for a started thread to ensure it doesn't it unparks in the event that the test fails.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12070/head:pull/12070$ git checkout pull/12070Update a local copy of the PR:
$ git checkout pull/12070$ git pull https://git.openjdk.org/jdk pull/12070/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12070View PR using the GUI difftool:
$ git pr show -t 12070Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12070.diff