8300644: Remove gc/shenandoah/jni/TestStringCriticalWithDedup.java

[fisk]

The gc/shenandoah/jni/TestStringCriticalWithDedup.java test was designed to catch failure to pin strings being passed out to JNI critical users, because that used to be dangerous. After JDK-8299673 that is not dangerous any longer. Conversely, now we kind of want deduplication to proceed regardless of JNI critical, which defeats the purpose of this test. It should be removed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300644: Remove gc/shenandoah/jni/TestStringCriticalWithDedup.java

Reviewers

• William Kemper (@earthling-amzn - no project role)
• Matthias Baesken (@MBaesken - Reviewer) ⚠️ Review applies to ca12e310

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12089/head:pull/12089
$ git checkout pull/12089

Update a local copy of the PR:
$ git checkout pull/12089
$ git pull https://git.openjdk.org/jdk pull/12089/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12089

View PR using the GUI difftool:
$ git pr show -t 12089

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12089.diff

[bridgekeeper]

👋 Welcome back eosterlund! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fisk The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ef92536b)
• 00: Full (ca12e310)

[earthling-amzn]

Looks like it will also be safe to delete libTestStringCriticalWithDedup.c.

[MBaesken]

LGTM

[openjdk]

@fisk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300644: Remove gc/shenandoah/jni/TestStringCriticalWithDedup.java

Reviewed-by: wkemper, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 163 new commits pushed to the master branch:

• 048705c: 8300910: Remove metaprogramming/integralConstant.hpp
• 544c16e: 8300266: Detect Virtualization on Linux aarch64
• 57f2d48: 8300863: Remove C-style array declarations in java.io
• 2292ce1: 8294677: chunklevel::MAX_CHUNK_WORD_SIZE too small for some applications
• 6dd8723: 8290918: Initial nroff manpage generation for JDK 21
• b3822f5: 8300589: Use @snippet and @linkplain in java.text.CollationKey and java.text.CompactNumberFormat
• afd5921: 8298610: Refactor archiving of ConstantPool::resolved_references()
• 937ba1c: 8300111: Add rpath for common lib locations for jpackageapplauncher
• 2da2e5a: 8300946: Add sun/security/provider/certpath/OCSP/OCSPNoContentLength to ProblemList
• 0323609: 8300706: Use @snippet in java.text
• ... and 153 more: https://git.openjdk.org/jdk/compare/a734285314a34ed61583132f2fc6be9d9c861af4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[fisk]

Looks like it will also be safe to delete libTestStringCriticalWithDedup.c.

Ah yeah, look at that. Fixed.

[fisk]

Thanks for the reviews, @MBaesken and @earthling-amzn!

[fisk]

/integrate

[openjdk]

Going to push as commit 95fafd0.
Since your change was applied there have been 174 commits pushed to the master branch:

• 5a478ef: 8297730: C2: Arraycopy intrinsic throws incorrect exception
• 7465de4: 6603771: Nimbus L&F: Ctrl+F7 keybinding for Jinternal Frame throws a NPE.
• fbe5ab0: 8300830: Remove redundant assertion in src/hotspot/share/runtime/javaCalls.cpp
• 1339461: 8300981: Build failure on 32-bit platforms after JDK-8281213
• 81d523d: Merge
• 60b8a98: 8300591: @SuppressWarnings option "lossy-conversions" missing from jdk.compiler module javadoc
• a3ed7e9: 8300623: Lambda deserialization regression involving Enum method reference
• cf46004: 8300272: Improve readability of the test JarWithOneNonDisabledDigestAlg
• b678e70: 8300942: JDK-8299684 breaks x86 build
• 3be5758: 8300769: Remove G1CollectionSet::_inc_bytes_used_before
• ... and 164 more: https://git.openjdk.org/jdk/compare/a734285314a34ed61583132f2fc6be9d9c861af4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@fisk Pushed as commit 95fafd0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.