8300682: InstanceKlassMiscStatus is a bad name

[coleenp]

This patch is to simply rename InstanceKlassMiscStatus to InstanceKlassFlags. This matches the naming for upcoming Field changes that add a FieldFlags class.
Tested with tier1-4.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300682: InstanceKlassMiscStatus is a bad name

Reviewers

• Frederic Parain (@fparain - Committer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12106/head:pull/12106
$ git checkout pull/12106

Update a local copy of the PR:
$ git checkout pull/12106
$ git pull https://git.openjdk.org/jdk pull/12106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12106

View PR using the GUI difftool:
$ git pr show -t 12106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12106.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[fparain]

LGTM, just minor nits in instanceKlassFlags.hpp.

[mlbridge]

Webrevs

• 01: Full - Incremental (2b79fd3c)
• 00: Full (fba9a31e)

[fparain]

LGTM, just minor nits in instanceKlassFlags.hpp.

[fparain]

The macro to prevent multiple inclusions should have the same name as the file after the renaming.
Should we add a comment stating that "Flags" are immutable, and mutable status should be put elsewhere?

[coleenp]

Oh whoops. Thank you for noticing that.

[coleenp]

I was going to put this comment when adding the mutable status class, in a following change.

[dholmes-ora]

Seems fine. Thanks.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300682: InstanceKlassMiscStatus is a bad name

Reviewed-by: fparain, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 77f2d20: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions
• 93a933d: 8300400: Update --release 20 symbol information for JDK 20 build 32
• 9b97699: 8300586: Refactor code examples to use @snippet in java.text.Collator
• fbbb27e: 8300356: Refactor code examples to use @snippet in java.text.CollationElementIterator
• dfcd65c: Merge
• 1c84050: 8298400: Virtual thread instability when stack overflows
• 62a2f23: 8300490: Spaces in name of MacOS Code Signing Identity are not correctly handled after JDK-8293550
• f2a1eb9: 8300698: Missing @SInCE tag for ClassFileFormatVersion.RELEASE_21
• 558d610: 8299553: Make ScaledEtchedBorderTest.java comprehensive
• 80ab50b: 8294680: Refactor scaled border rendering
• ... and 1 more: https://git.openjdk.org/jdk/compare/d85243f02b34d03bd7af63a5bcbc73f500f720df...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thanks Fred and David.
/integrate

[openjdk]

Going to push as commit 4562b40.
Since your change was applied there have been 15 commits pushed to the master branch:

• 26410c1: 8281213: Unsafe uses of long and size_t in MemReporterBase::diff_in_current_scale
• eca6479: 8300087: Replace NULL with nullptr in share/cds/
• 49d60fe: 8300172: java/net/httpclient/MappingResponseSubscriber.java failed with java.net.ConnectException
• e189397: 8296403: [TESTBUG] IR test runner methods in TestLongRangeChecks.java invoke wrong test methods
• 77f2d20: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions
• 93a933d: 8300400: Update --release 20 symbol information for JDK 20 build 32
• 9b97699: 8300586: Refactor code examples to use @snippet in java.text.Collator
• fbbb27e: 8300356: Refactor code examples to use @snippet in java.text.CollationElementIterator
• dfcd65c: Merge
• 1c84050: 8298400: Virtual thread instability when stack overflows
• ... and 5 more: https://git.openjdk.org/jdk/compare/d85243f02b34d03bd7af63a5bcbc73f500f720df...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 4562b40.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.