Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8300698: Missing @since tag for ClassFileFormatVersion.RELEASE_21 #12107

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Jan 19, 2023

The addition of the new enum constant for ClassFileFormatVersion.RELEASE_21 neglected to include an @SInCE tag; this should be corrected.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12107/head:pull/12107
$ git checkout pull/12107

Update a local copy of the PR:
$ git checkout pull/12107
$ git pull https://git.openjdk.org/jdk pull/12107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12107

View PR using the GUI difftool:
$ git pr show -t 12107

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12107.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2023

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300698: Missing @since tag for ClassFileFormatVersion.RELEASE_21

Reviewed-by: rriggs, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 19, 2023
@jddarcy
Copy link
Member Author

jddarcy commented Jan 19, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 19, 2023

Going to push as commit f2a1eb9.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 19, 2023
@openjdk openjdk bot closed this Jan 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@jddarcy Pushed as commit f2a1eb9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants