8300591: @SuppressWarnings option "lossy-conversions" missing from jdk.compiler module javadoc

[asotona]

Hi,
@SuppressWarnings option "lossy-conversions" has been added to JDK 20 (see JDK-8286377), however the option description is missing in jdk.compiler module javadoc and javac man page.
This patch add missing javadoc decription to jdk.compiler module-info.java

Please review.

Thanks,
Adam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Change requires CSR request JDK-8300740 to be approved
• Commit message must refer to an issue

Issues

• JDK-8300591: @SuppressWarnings option "lossy-conversions" missing from jdk.compiler module javadoc
• JDK-8300740: Add @SuppressWarnings option "lossy-conversions" description to jdk.compiler module javadoc and javac man page (CSR)

Reviewers

• Jonathan Gibbons (@jonathan-gibbons - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12111/head:pull/12111
$ git checkout pull/12111

Update a local copy of the PR:
$ git checkout pull/12111
$ git pull https://git.openjdk.org/jdk pull/12111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12111

View PR using the GUI difftool:
$ git pr show -t 12111

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12111.diff

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (64c9bcc6)
• 00: Full (55c78a53)

[archiecobbs]

The current patch doesn't include a man page update (the bug refers to both Javadoc and man page).

That's OK but if so then maybe the bug should be split into two as well so the man page part of the issue can be tracked?

[jonathan-gibbons]

The current patch doesn't include a man page update (the bug refers to both Javadoc and man page).

That's OK but if so then maybe the bug should be split into two as well so the man page part of the issue can be tracked?

We should try and do the man page at this time as well.

[asotona]

I've included also man page update.

[jddarcy]

In the table where there is more room to accommodate text, perhaps a longer description mentioning primitive types could be used.

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300591: @SuppressWarnings option "lossy-conversions" missing from jdk.compiler module javadoc

Reviewed-by: jjg, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 7c2f77a: 8300584: Accelerate AVX-512 CRC32C for small buffers
• 5784eb7: 8300721: Cleanup ProblemList-svc-vthread.txt
• 9d44dd0: 8297972: Poly1305 Endianness on ByteBuffer not enforced
• facd415: 8297757: VarHandles.getStaticFieldFromBaseAndOffset should get the receiver type from VarHandle
• e803855: 8299863: URLFromURITest.java should import org.junit.jupiter.api.Test
• 92d8326: 8299827: Add resolved IP address in connection exception for sockets
• c6d5600: 8038146: Clarify Map.Entry's connection to the underlying map
• b2d3622: 8299896: Reduce enum values of HtmlLinkInfo.Kind
• 623ba5b: 8300653: G1EvacInfo should use common naming scheme for collection set
• 97c611d: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
• ... and 1 more: https://git.openjdk.org/jdk/compare/26410c180b88b4342217fdad63f1221786d8c37b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[asotona]

/integrate

[openjdk]

Going to push as commit 836198a.
Since your change was applied there have been 23 commits pushed to the master branch:

• 45e4e00: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
• 030b071: 8300207: Add a pre-check for the number of canonical equivalent permutations in j.u.r.Pattern
• 7ced08d: 8300638: Tier1 IR Test failure after JDK-8298632 on macosx-x64-debug
• 3ea4eac: 8300817: The build is broken after JDK-8294693
• cbfc069: 8300731: Avoid unnecessary array fill after creation in PaletteBuilder
• 67b1c89: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface
• c8dd758: 8300260: Remove metaprogramming/isSame.hpp
• a6c2a2a: 8300692: GCC 12 reports some compiler warnings in bundled freetype
• bb42e61: 8300493: Use ArraysSupport.vectorizedHashCode in j.u.zip.ZipCoder
• 06394ee: 8300590: [JVMCI] BytecodeFrame.equals is broken
• ... and 13 more: https://git.openjdk.org/jdk/compare/26410c180b88b4342217fdad63f1221786d8c37b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona Pushed as commit 836198a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.