8300863: Remove C-style array declarations in java.io

[minborg]

Some variables are declared using old-style declarations. These should be modified to conform to modern style.

This is a task derived from #11848

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300863: Remove C-style array declarations in java.io

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Roger Riggs (@RogerRiggs - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)
• Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12139/head:pull/12139
$ git checkout pull/12139

Update a local copy of the PR:
$ git checkout pull/12139
$ git pull https://git.openjdk.org/jdk pull/12139/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12139

View PR using the GUI difftool:
$ git pr show -t 12139

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12139.diff

[bridgekeeper]

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@minborg The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5107c341)

[openjdk]

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300863: Remove C-style array declarations in java.io

Reviewed-by: alanb, rriggs, darcy, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 1a3cb8c: 8296343: CPVE thrown on missing content-length in OCSP response
• 86fed79: 8300693: Lower the compile threshold and reduce the iterations of warmup loop in VarHandles tests
• 4525aa3: 8300867: Fix document issues in java.io
• a7f035d: 8300868: Reduce visibility in java.io.SerialCallbackContext
• 079255e: 8300864: Declare some fields in java.io as final
• a56598f: 8299684: (bf) JNI direct buffer functions with large capacity behave unexpectedly
• 542bfe6: 8300587: (bf) Some covariant overrides are missing @SInCE tags
• 03a9a88: 8300265: Remove metaprogramming/isSigned.hpp
• 5a4945c: 8299975: Limit underflow protection CMoveINode in PhaseIdealLoop::do_unroll must also protect type from underflow

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[minborg]

/integrate

[jddarcy]

Nice cleanup.

[openjdk]

@minborg Unable to acquire the integration lock; aborting integration. The error has been logged and will be investigated.

[erikj79]

Something is causing high contention in the bot, it's under investigation. In the meantime, all you can do is retry this /integrate command until it goes through.

[minborg]

/integrate

[openjdk]

Going to push as commit 57f2d48.
Since your change was applied there have been 24 commits pushed to the master branch:

• 2292ce1: 8294677: chunklevel::MAX_CHUNK_WORD_SIZE too small for some applications
• 6dd8723: 8290918: Initial nroff manpage generation for JDK 21
• b3822f5: 8300589: Use @snippet and @linkplain in java.text.CollationKey and java.text.CompactNumberFormat
• afd5921: 8298610: Refactor archiving of ConstantPool::resolved_references()
• 937ba1c: 8300111: Add rpath for common lib locations for jpackageapplauncher
• 2da2e5a: 8300946: Add sun/security/provider/certpath/OCSP/OCSPNoContentLength to ProblemList
• 0323609: 8300706: Use @snippet in java.text
• b5ee3d1: 8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs
• 77a5010: 8286775: Remove identical per-compiler definitions of unsigned integral jtypes
• f79e587: 8300828: Avoid unnecessary array fill after creation in com.sun.media.sound
• ... and 14 more: https://git.openjdk.org/jdk/compare/f307e8c667895c302e916124751456a5443353ce...master

Your commit was automatically rebased without conflicts.

[openjdk]

@minborg Pushed as commit 57f2d48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.