8300864: Declare some fields in java.io as final

[minborg]

Some of the fields in java.io can be declared as final.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300864: Declare some fields in java.io as final

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)
• Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12140/head:pull/12140
$ git checkout pull/12140

Update a local copy of the PR:
$ git checkout pull/12140
$ git pull https://git.openjdk.org/jdk pull/12140/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12140

View PR using the GUI difftool:
$ git pr show -t 12140

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12140.diff

[bridgekeeper]

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@minborg The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4afde0fe)

[LanceAndersen]

The changes look reasonable to me

[openjdk]

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300864: Declare some fields in java.io as final

Reviewed-by: rriggs, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• a56598f: 8299684: (bf) JNI direct buffer functions with large capacity behave unexpectedly
• 542bfe6: 8300587: (bf) Some covariant overrides are missing @SInCE tags
• 03a9a88: 8300265: Remove metaprogramming/isSigned.hpp
• 5a4945c: 8299975: Limit underflow protection CMoveINode in PhaseIdealLoop::do_unroll must also protect type from underflow

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[minborg]

/integrate

[openjdk]

Going to push as commit 079255e.
Since your change was applied there have been 4 commits pushed to the master branch:

• a56598f: 8299684: (bf) JNI direct buffer functions with large capacity behave unexpectedly
• 542bfe6: 8300587: (bf) Some covariant overrides are missing @SInCE tags
• 03a9a88: 8300265: Remove metaprogramming/isSigned.hpp
• 5a4945c: 8299975: Limit underflow protection CMoveINode in PhaseIdealLoop::do_unroll must also protect type from underflow

Your commit was automatically rebased without conflicts.

[openjdk]

@minborg Pushed as commit 079255e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[AlanBateman]

It's a pity to rename this one as FS.* is very ugly.