Skip to content

8300958: Parallel: Remove unused MutableNUMASpace::capacity_in_words #12162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jan 24, 2023

Trivial removing dead code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300958: Parallel: Remove unused MutableNUMASpace::capacity_in_words

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12162/head:pull/12162
$ git checkout pull/12162

Update a local copy of the PR:
$ git checkout pull/12162
$ git pull https://git.openjdk.org/jdk pull/12162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12162

View PR using the GUI difftool:
$ git pr show -t 12162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12162.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8300958 8300958: Parallel: Remove unused MutableNUMASpace::capacity_in_words Jan 24, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 24, 2023
@openjdk
Copy link

openjdk bot commented Jan 24, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 24, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2023

Webrevs

@@ -89,7 +89,6 @@ class MutableSpace: public CHeapObj<mtGC> {

size_t capacity_in_bytes() const { return capacity_in_words() * HeapWordSize; }
size_t capacity_in_words() const { return pointer_delta(end(), bottom()); }
virtual size_t capacity_in_words(Thread*) const { return capacity_in_words(); }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the copyright year?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't add any new code, so probably not applicable.

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jan 24, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300958: Parallel: Remove unused MutableNUMASpace::capacity_in_words

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 544c16e: 8300266: Detect Virtualization on Linux aarch64
  • 57f2d48: 8300863: Remove C-style array declarations in java.io

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 24, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 26, 2023

Going to push as commit 7328182.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 30cb305: 8292170: Convert CodeRootSetTable to use ResourceHashtable
  • 3589b80: 8300127: Serial: Remove unnecessary from-space iteration in DefNewGeneration::oop_since_save_marks_iterate
  • 48152ef: 8287134: HttpURLConnection chunked streaming mode doesn't enforce specified size
  • 4b0e656: 8298118: split-if optimization causes empty loop to temporarily have more than one phi
  • 252621d: 8301063: Remove dead code from GrowableArray
  • b5a4744: 8300857: State return value for Types.asElement(NoType) explicitly
  • 7e951f4: 8301092: Add benchmark for CRC32
  • adcfd25: 8301098: Remove dead code FileMapInfo::stop_sharing_and_unmap()
  • 9f0887e: 8296661: Typo Found In CSSParser.java
  • ccf2f58: 8300806: Update googletest to v1.13.0
  • ... and 27 more: https://git.openjdk.org/jdk/compare/2292ce137c16accf0622600d5a096403b8a8058d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 26, 2023
@openjdk openjdk bot closed this Jan 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@albertnetymk Pushed as commit 7328182.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the pgc-remove-dead branch January 26, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants