8300997: Add curl support to createJMHBundle.sh

[eirbjo]

Please review this PR which updates make/devkit/createJMHBundle.sh to add support for curl instead of wget when downloading JMH dependencies.

This would reduce friction for MacOS devs who would like to run micros without installing wget first.

File download is extracted to a function taking the Maven directory, artifactId and version as input. The function builds the correct download URL and checks which of curl / wget is available.

Tested on MacOS 12.6.2 and Ubuntu 20.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300997: Add curl support to createJMHBundle.sh

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12164/head:pull/12164
$ git checkout pull/12164

Update a local copy of the PR:
$ git checkout pull/12164
$ git pull https://git.openjdk.org/jdk pull/12164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12164

View PR using the GUI difftool:
$ git pr show -t 12164

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12164.diff

[bridgekeeper]

👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@eirbjo The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[erikj79]

Filed https://bugs.openjdk.org/browse/JDK-8300997

[openjdk]

@eirbjo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300997: Add curl support to createJMHBundle.sh

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• a5d8e12: 8300244: Replace NULL with nullptr in share/interpreter/
• 71107f4: 8300651: Replace NULL with nullptr in share/runtime/
• 3c61d5a: 8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values
• b2071f7: 8300657: Remove null filtering in CLD oop handle area
• 95fafd0: 8300644: Remove gc/shenandoah/jni/TestStringCriticalWithDedup.java
• 5a478ef: 8297730: C2: Arraycopy intrinsic throws incorrect exception
• 7465de4: 6603771: Nimbus L&F: Ctrl+F7 keybinding for Jinternal Frame throws a NPE.
• fbe5ab0: 8300830: Remove redundant assertion in src/hotspot/share/runtime/javaCalls.cpp
• 1339461: 8300981: Build failure on 32-bit platforms after JDK-8281213
• 81d523d: Merge
• ... and 11 more: https://git.openjdk.org/jdk/compare/b3822f50c85524a00a045aa3a3d902f190e35906...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (6427686a)

[eirbjo]

/integrate

[openjdk]

@eirbjo
Your change (at version 6427686) is now ready to be sponsored by a Committer.

[eirbjo]

@erikj79 Thanks for your review and help with the JBS, much appreciated!

Will you also be willing to sponsor?

[erikj79]

/sponsor

[openjdk]

Going to push as commit 61775c8.
Since your change was applied there have been 24 commits pushed to the master branch:

• 8a47429: 8295944: Move the Http2TestServer and related classes into a package of its own
• c8ad600: 8301004: httpclient: Add more debug to HttpResponseInputStream
• 74e1a8b: 8300236: Use VarHandle access in Data(Input | Output)Stream classes
• a5d8e12: 8300244: Replace NULL with nullptr in share/interpreter/
• 71107f4: 8300651: Replace NULL with nullptr in share/runtime/
• 3c61d5a: 8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values
• b2071f7: 8300657: Remove null filtering in CLD oop handle area
• 95fafd0: 8300644: Remove gc/shenandoah/jni/TestStringCriticalWithDedup.java
• 5a478ef: 8297730: C2: Arraycopy intrinsic throws incorrect exception
• 7465de4: 6603771: Nimbus L&F: Ctrl+F7 keybinding for Jinternal Frame throws a NPE.
• ... and 14 more: https://git.openjdk.org/jdk/compare/b3822f50c85524a00a045aa3a3d902f190e35906...master

Your commit was automatically rebased without conflicts.

[openjdk]

@erikj79 @eirbjo Pushed as commit 61775c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.