8256323: Remove HeapRegionManager::update_committed_space()

[tschatzl]

Hi all,

can I have reviews for this trivial removal of the unimplemented function declaration of HeapRegionManager::update_committed_space()?

Testing: local compilation

Thanks,
Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8256323: Remove HeapRegionManager::update_committed_space()

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Stefan Johansson (@kstefanj - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1219/head:pull/1219
$ git checkout pull/1219

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cbde02d)

[shipilev]

Looks fine and trivial.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256323: Remove HeapRegionManager::update_committed_space()

Reviewed-by: shade, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @shipilev @kstefanj for the reviews.

/integrate

[openjdk]

@tschatzl Pushed as commit ac39489.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.