Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256323: Remove HeapRegionManager::update_committed_space() #1219


Copy link

@tschatzl tschatzl commented Nov 16, 2020

Hi all,

can I have reviews for this trivial removal of the unimplemented function declaration of HeapRegionManager::update_committed_space()?

Testing: local compilation



  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8256323: Remove HeapRegionManager::update_committed_space()



$ git fetch pull/1219/head:pull/1219
$ git checkout pull/1219

Copy link

@bridgekeeper bridgekeeper bot commented Nov 16, 2020

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 16, 2020
Copy link

@openjdk openjdk bot commented Nov 16, 2020

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 16, 2020
Copy link

@mlbridge mlbridge bot commented Nov 16, 2020


Copy link

@shipilev shipilev left a comment

Looks fine and trivial.

Copy link

@openjdk openjdk bot commented Nov 16, 2020

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8256323: Remove HeapRegionManager::update_committed_space()

Reviewed-by: shade, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 16, 2020
Copy link
Contributor Author

@tschatzl tschatzl commented Nov 16, 2020

Thanks @shipilev @kstefanj for the reviews.


@openjdk openjdk bot closed this Nov 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 16, 2020
Copy link

@openjdk openjdk bot commented Nov 16, 2020

@tschatzl Pushed as commit ac39489.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the 8256323-remove-update-committed-space branch Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
hotspot-gc integrated
3 participants