8236142: DocTrees should provide getCharacters(EntityTree)

[jonathan-gibbons]

A new method is added to the DocTrees utility class to return the characters represented by a named or numeric entity, as represented in an EntityTree.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8236142: DocTrees should provide getCharacters(EntityTree)

Reviewers

• Pavel Rappo (@pavelrappo - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/122/head:pull/122
$ git checkout pull/122

[jonathan-gibbons]

/csr

[bridgekeeper]

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jonathan-gibbons has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@jonathan-gibbons this pull request must refer to an issue in JBS to be able to link it to a CSR request. To refer this pull request to an issue in JBS, please use the /issue command in a comment in this pull request.

[openjdk]

@jonathan-gibbons The following labels will be automatically applied to this pull request: compiler javadoc.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1d3489c)
• 00: Full (33f2e63)

[jonathan-gibbons]

Note that as well as the simple move for the Entity.java file, the init for the class is optimized to be significantly smaller byte codes. That particular change was automated: there should be no change to the set of strings that are accepted by the class.

[openjdk]

@pavelrappo Unknown command approve - for a list of valid commands use /help.

[pavelrappo]

/help

[openjdk]

@pavelrappo Available commands:

• cc - add or remove an additional classification label
• contributor - adds or removes additional contributors for a PR
• covered - used when employer has signed the OCA
• csr - require a compatibility and specification request (CSR) for this pull request
• help - shows this text
• integrate - performs integration of the changes in the PR
• issue - edit the list of issues that this PR solves
• label - add or remove an additional classification label
• reviewer - manage additional reviewers for a PR
• reviewers - set the number of additional required reviewers for this PR
• signed - used after signing the OCA
• solves - edit the list of issues that this PR solves
• sponsor - performs integration of a PR that is authored by a non-committer
• summary - updates the summary in the commit message
• test - used to run tests

[pavelrappo]

/reviewer add @pavelrappo

[openjdk]

@pavelrappo Only the author (@jonathan-gibbons) is allowed to issue the reviewer command.

[jonathan-gibbons]

/reviewer @pavelrappo

[openjdk]

@jonathan-gibbons Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

• /reviewer credit @openjdk-bot
• /reviewer credit duke
• /reviewer credit @user1 @user2

[openjdk]

@jonathan-gibbons This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8236142: DocTrees should provide getCharacters(EntityTree)

Reviewed-by: prappo

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 20 commits pushed to the master branch:

• e7a1b9b: 8252981: ObjectMonitor::object() cleanup changes extracted from JDK-8247281
• 040c8f5: 8250914: Matcher::stack_direction() is unused
• 9687dca: 8252494: C2: TypeAryPtr::cast_to_autobox_cache does not use ptr_type
• 8777ded: 8253008: Remove develop flags TraceLongCompiles/LongCompileThreshold
• c7062dc: 8253026: Remove dummy call to gc alot from VM Thread
• 5144190: 8243208: Clean up JVMFlag implementation
• 976acdd: 8252406: Introduce Thread::as_Java_thread() convenience function
• 4880226: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux
• 8da6c8d: 7183828: Invalid Image Variant when using anything other than BufferedImage
• ff21696: 8252817: Cleanup the classes in the java.awt.color package
• ... and 10 more: https://git.openjdk.java.net/jdk/compare/433394203dce55db95caefcb57bac9ec114ebc47...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e7a1b9bf81c78e8c90310c0cdc4e6e0384956448.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jonathan-gibbons]

/integrate

[openjdk]

@jonathan-gibbons Since your change was applied there have been 20 commits pushed to the master branch:

• e7a1b9b: 8252981: ObjectMonitor::object() cleanup changes extracted from JDK-8247281
• 040c8f5: 8250914: Matcher::stack_direction() is unused
• 9687dca: 8252494: C2: TypeAryPtr::cast_to_autobox_cache does not use ptr_type
• 8777ded: 8253008: Remove develop flags TraceLongCompiles/LongCompileThreshold
• c7062dc: 8253026: Remove dummy call to gc alot from VM Thread
• 5144190: 8243208: Clean up JVMFlag implementation
• 976acdd: 8252406: Introduce Thread::as_Java_thread() convenience function
• 4880226: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux
• 8da6c8d: 7183828: Invalid Image Variant when using anything other than BufferedImage
• ff21696: 8252817: Cleanup the classes in the java.awt.color package
• ... and 10 more: https://git.openjdk.java.net/jdk/compare/433394203dce55db95caefcb57bac9ec114ebc47...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7f27d0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.