Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301132: Test update for deprecated sprintf in Xcode 14 #12211

Closed
wants to merge 2 commits into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Jan 26, 2023

The sprintf is deprecated in Xcode 14 because of security concerns. The issue was addressed in JDK-8296812/JDK-8299378/JDK-8299635, but the test was not fully covered yet. This would be the last effort to fix the issue in test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301132: Test update for deprecated sprintf in Xcode 14

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12211/head:pull/12211
$ git checkout pull/12211

Update a local copy of the PR:
$ git checkout pull/12211
$ git pull https://git.openjdk.org/jdk pull/12211/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12211

View PR using the GUI difftool:
$ git pr show -t 12211

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12211.diff

@XueleiFan XueleiFan marked this pull request as ready for review January 26, 2023 06:48
@XueleiFan
Copy link
Member Author

/issue JDK-8301132

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2023

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@XueleiFan This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@XueleiFan The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels Jan 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301132: Test update for deprecated sprintf in Xcode 14

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

  • 7aaf76c: 8300924: Method::invoke throws wrong exception type when passing wrong number of arguments to method with 4 or more parameters
  • 49ff520: 8300241: Replace NULL with nullptr in share/classfile/
  • f52d35c: 8300240: Replace NULL with nullptr in share/ci/
  • 5c1ec82: 8301077: Replace NULL with nullptr in share/services/
  • dff4131: 8285850: [AIX] unreachable code in basic_tools.m4 -> BASIC_CHECK_TAR
  • e2a3b20: 8301187: Memory leaks in OopMapCache
  • fccf818: 8301123: Enable Symbol refcounting underflow checks in PRODUCT
  • e4252bb: 8300823: UB: Compile::_phase_optimize_finished is initialized too late
  • db8fa1b: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case
  • 3758487: 8301180: Replace NULL with nullptr in share/gc/parallel/
  • ... and 33 more: https://git.openjdk.org/jdk/compare/b5a4744f9019f76664738029f13b4d4f651d20d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 27, 2023
@XueleiFan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 27, 2023

Going to push as commit 9c4bc2c.
Since your change was applied there have been 45 commits pushed to the master branch:

  • 7f05d57: 8217920: Lookup.defineClass injects a class that can access private members of any class in its own module
  • 22c976a: 8177418: NPE is not apparent for methods in java.util.TimeZone API docs
  • 7aaf76c: 8300924: Method::invoke throws wrong exception type when passing wrong number of arguments to method with 4 or more parameters
  • 49ff520: 8300241: Replace NULL with nullptr in share/classfile/
  • f52d35c: 8300240: Replace NULL with nullptr in share/ci/
  • 5c1ec82: 8301077: Replace NULL with nullptr in share/services/
  • dff4131: 8285850: [AIX] unreachable code in basic_tools.m4 -> BASIC_CHECK_TAR
  • e2a3b20: 8301187: Memory leaks in OopMapCache
  • fccf818: 8301123: Enable Symbol refcounting underflow checks in PRODUCT
  • e4252bb: 8300823: UB: Compile::_phase_optimize_finished is initialized too late
  • ... and 35 more: https://git.openjdk.org/jdk/compare/b5a4744f9019f76664738029f13b4d4f651d20d6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 27, 2023
@openjdk openjdk bot closed this Jan 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2023
@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@XueleiFan Pushed as commit 9c4bc2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8301132 branch January 27, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants