Skip to content

8301164: Remove unused ResourceStack class #12221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jan 26, 2023

Trivial removing dead code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12221/head:pull/12221
$ git checkout pull/12221

Update a local copy of the PR:
$ git checkout pull/12221
$ git pull https://git.openjdk.org/jdk pull/12221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12221

View PR using the GUI difftool:
$ git pr show -t 12221

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12221.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8301164 8301164: Remove unused ResourceStack class Jan 26, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2023

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good + trivial.

@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301164: Remove unused ResourceStack class

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 315398c: 8221785: Let possibly_parallel_threads_do cover the same threads as threads_do
  • 14114c2: 8301005: Clean up Copy::conjoint_*_atomic on windows
  • 973f741: 8300968: Accessorize raw oop load in DeadCounterClosure
  • 64ddf95: 8299858: [Metrics] Swap memory limit reported incorrectly when too large
  • 28545dc: 8300247: Harden C1 xchg on AArch64 and PPC
  • 3f63381: 8300913: ZGC: assert(to_addr != 0) failed: Should be forwarded

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 26, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 27, 2023

Going to push as commit f7da09c.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 6e4710b: 8300253: Introduce AArch64 nzcv accessors
  • c6b3f2d: 8301129: Link to debuginfo files should only be made after stripping
  • 938b409: 8301133: IGV: NPE occurs when creating a diff graph with a graph in a different folder
  • 0eb1f66: 8298038: [s390] Configure script detects num_cores +1
  • c3ff151: 8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr
  • 7eff578: 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider
  • d6007a3: 8298869: Update ConnectionTest.java for changes to TLS implementation
  • c427814: 8299982: (bf) Buffer.checkIndex(int, int) should use Preconditions.checkIndex(int, int, BiFunction)
  • 7ddafd7: 8301189: validate-source fails after JDK-8298873
  • fc26d3e: 8298873: Update IllegalRecordVersion.java for changes to TLS implementation
  • ... and 8 more: https://git.openjdk.org/jdk/compare/da80e7a489684cdc5d52ac07868961f889f2dc34...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 27, 2023
@openjdk openjdk bot closed this Jan 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2023
@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@albertnetymk Pushed as commit f7da09c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the trivial branch January 27, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants