Skip to content

8301189: validate-source fails after JDK-8298873 #12232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mpdonova
Copy link
Contributor

@mpdonova mpdonova commented Jan 26, 2023

fixed copyright header


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12232/head:pull/12232
$ git checkout pull/12232

Update a local copy of the PR:
$ git checkout pull/12232
$ git pull https://git.openjdk.org/jdk pull/12232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12232

View PR using the GUI difftool:
$ git pr show -t 12232

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12232.diff

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2023

👋 Welcome back mpdonova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member

The file is also missing an EOL on the last line.

@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301189: validate-source fails after JDK-8298873

Reviewed-by: dcubed, rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dcubed-ojdk, @rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@mpdonova The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jan 26, 2023
@mpdonova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@mpdonova
Your change (at version ac6e0a3) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented Jan 26, 2023

Webrevs

@rhalade
Copy link
Member

rhalade commented Jan 26, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 26, 2023

Going to push as commit 7ddafd7.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 26, 2023
@openjdk openjdk bot closed this Jan 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@rhalade @mpdonova Pushed as commit 7ddafd7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants