8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr

[Glavo]

When the default Locale is tr, the letter i will be converted to İ (U+0130) by toUpperCase(). This causes the assertion to fail.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr

Reviewers

• Paul Sandoz (@PaulSandoz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12238/head:pull/12238
$ git checkout pull/12238

Update a local copy of the PR:
$ git checkout pull/12238
$ git pull https://git.openjdk.org/jdk pull/12238/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12238

View PR using the GUI difftool:
$ git pr show -t 12238

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12238.diff

[bridgekeeper]

👋 Welcome back Glavo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Glavo To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[Glavo]

/label core-libs

[openjdk]

@Glavo
The core-libs label was successfully added.

[mlbridge]

Webrevs

• 00: Full (4963c0e7)

[PaulSandoz]

Looks good. I am grateful the assert was in place.

[openjdk]

@Glavo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 7eff578: 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@PaulSandoz) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[Glavo]

/integrate

[openjdk]

@Glavo
Your change (at version 4963c0e) is now ready to be sponsored by a Committer.

[PaulSandoz]

/sponsor

[openjdk]

Going to push as commit c3ff151.
Since your change was applied there has been 1 commit pushed to the master branch:

• 7eff578: 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider

Your commit was automatically rebased without conflicts.

[openjdk]

@PaulSandoz @Glavo Pushed as commit c3ff151.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.