-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8298979: Remove duplicated serviceability/jvmti/thread/GetAllThreads/allthr01/allthr01.java #12240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks good to me.
It is nice to remove the duplication.
Thanks,
Serguei
@lmesnik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 78 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 2d50c7d.
Your commit was automatically rebased without conflicts. |
PR adds fix "8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing" to new test and remove duplication.
Test allthr002 ported as
serviceability/jvmti/negative/GetAllThreadsNullTest/GetAllThreadsNullTest.java
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12240/head:pull/12240
$ git checkout pull/12240
Update a local copy of the PR:
$ git checkout pull/12240
$ git pull https://git.openjdk.org/jdk pull/12240/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12240
View PR using the GUI difftool:
$ git pr show -t 12240
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12240.diff