JDK-8301163: jdk/internal/vm/Continuation/Fuzz.java increase COMPILATION_TIMEOUT for Linux ppc64le #12244

MBaesken · 2023-01-27T08:33:32Z

On our Linux ppc64le test machines we quite often see compilation timeouts in the test jdk/internal/vm/Continuation/Fuzz.java.
(especially when running with fastdebug binaries)
So it probably makes sense to use a higher compilation timeout (maybe factor 2) on this platform.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8301163: jdk/internal/vm/Continuation/Fuzz.java increase COMPILATION_TIMEOUT for Linux ppc64le

Reviewers

Richard Reingruber (@reinrich - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12244/head:pull/12244
$ git checkout pull/12244

Update a local copy of the PR:
$ git checkout pull/12244
$ git pull https://git.openjdk.org/jdk pull/12244/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12244

View PR using the GUI difftool:
$ git pr show -t 12244

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12244.diff

bridgekeeper · 2023-01-27T08:35:19Z

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-01-27T08:37:48Z

@MBaesken The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-01-27T08:40:48Z

Webrevs

reinrich · 2023-01-27T08:41:12Z

test/jdk/jdk/internal/vm/Continuation/Fuzz.java

@@ -91,6 +91,9 @@ public static void main(String[] args) {
            throw new SkippedException("Test is unstable with slowdebug bits "
                                       + "on macosx-aarch64");
        }
+        if (Platform.isLinux() && Platform.isPPC()) {


I wouldn't limit to Linux.

I changed it, removed the Linux related check.

reinrich · 2023-01-27T10:07:31Z

test/jdk/jdk/internal/vm/Continuation/Fuzz.java

@@ -91,6 +91,9 @@ public static void main(String[] args) {
            throw new SkippedException("Test is unstable with slowdebug bits "
                                       + "on macosx-aarch64");
        }
+        if (Platform.isPPC()) {
+            COMPILATION_TIMEOUT = COMPILATION_TIMEOUT * 2;


I guess this won't compile. COMPILATION_TIMEOUT is final.

Yes correct, it cannot be final any more.

Well it could be final if you would add (Platform.isPPC() ? 2 : 1) * ... to the initialization. But I'm indifferent.

openjdk · 2023-01-27T10:21:52Z

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301163: jdk/internal/vm/Continuation/Fuzz.java increase COMPILATION_TIMEOUT for Linux ppc64le

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

107e184: 8301179: Replace NULL with nullptr in share/gc/serial/
b77abc6: 8301178: Replace NULL with nullptr in share/gc/epsilon/
f7da09c: 8301164: Remove unused ResourceStack class
6e4710b: 8300253: Introduce AArch64 nzcv accessors
c6b3f2d: 8301129: Link to debuginfo files should only be made after stripping
938b409: 8301133: IGV: NPE occurs when creating a diff graph with a graph in a different folder
0eb1f66: 8298038: [s390] Configure script detects num_cores +1
c3ff151: 8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr
7eff578: 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider
d6007a3: 8298869: Update ConnectionTest.java for changes to TLS implementation
... and 5 more: https://git.openjdk.org/jdk/compare/315398c2450e47d9cdb7fac944e35ba6a6aef221...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

MBaesken · 2023-01-30T08:14:03Z

/integrate

openjdk · 2023-01-30T08:15:20Z

Going to push as commit cbefe1f.
Since your change was applied there have been 43 commits pushed to the master branch:

c2ebd17: 6187113: DefaultListSelectionModel.removeIndexInterval(0, Integer.MAX_VALUE) fails
4bd3f0a: 8301088: oopDesc::print_on should consistently use a trailing newline
64b25ea: 8291569: Consider removing JNI checks for signals SIGPIPE and SIGXFSZ
1ff4646: 8298612: Refactor archiving of java String objects
d4e9f5e: 8238170: BeanContextSupport remove and propertyChange can deadlock
6475501: 8300208: Optimize Adler32 stub for AVX-512 targets.
af564e4: 8299844: RISC-V: Implement _onSpinWait intrinsic
5dfc4ec: 8300140: ZipFile.isSignatureRelated returns true for files in META-INF subdirectories
5c59de5: Merge
e5860ef: 8301206: Fix issue with LocaleData after JDK-8300719
... and 33 more: https://git.openjdk.org/jdk/compare/315398c2450e47d9cdb7fac944e35ba6a6aef221...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-01-30T08:15:32Z

@MBaesken Pushed as commit cbefe1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8301163

856c99c

openjdk bot added the rfr Pull request is ready for review label Jan 27, 2023

openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 27, 2023

reinrich reviewed Jan 27, 2023

View reviewed changes

Do not limit to Linux, handle all PPC platforms

74f2b80

reinrich reviewed Jan 27, 2023

View reviewed changes

COMPILATION_TIMEOUT cannot be final

e8e3c3c

reinrich approved these changes Jan 27, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 27, 2023

openjdk bot added the integrated Pull request has been integrated label Jan 30, 2023

openjdk bot closed this Jan 30, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

JDK-8301163: jdk/internal/vm/Continuation/Fuzz.java increase COMPILATION_TIMEOUT for Linux ppc64le #12244

JDK-8301163: jdk/internal/vm/Continuation/Fuzz.java increase COMPILATION_TIMEOUT for Linux ppc64le #12244

Uh oh!

MBaesken commented Jan 27, 2023 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Jan 27, 2023

Uh oh!

openjdk bot commented Jan 27, 2023

Uh oh!

mlbridge bot commented Jan 27, 2023 •

edited

Loading

Uh oh!

reinrich Jan 27, 2023

Uh oh!

MBaesken Jan 27, 2023

Uh oh!

reinrich Jan 27, 2023

Uh oh!

MBaesken Jan 27, 2023

Uh oh!

reinrich Jan 27, 2023

Uh oh!

openjdk bot commented Jan 27, 2023

Uh oh!

MBaesken commented Jan 30, 2023

Uh oh!

openjdk bot commented Jan 30, 2023

Uh oh!

openjdk bot commented Jan 30, 2023

Uh oh!

Uh oh!

JDK-8301163: jdk/internal/vm/Continuation/Fuzz.java increase COMPILATION_TIMEOUT for Linux ppc64le #12244

JDK-8301163: jdk/internal/vm/Continuation/Fuzz.java increase COMPILATION_TIMEOUT for Linux ppc64le #12244

Uh oh!

Conversation

MBaesken commented Jan 27, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jan 27, 2023

Uh oh!

openjdk bot commented Jan 27, 2023

Uh oh!

mlbridge bot commented Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

reinrich Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

MBaesken Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

reinrich Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

MBaesken Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

reinrich Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Jan 27, 2023

Uh oh!

MBaesken commented Jan 30, 2023

Uh oh!

openjdk bot commented Jan 30, 2023

Uh oh!

openjdk bot commented Jan 30, 2023

Uh oh!

Uh oh!

MBaesken commented Jan 27, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Jan 27, 2023 •

edited

Loading