Skip to content

8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test #12257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sisahoo
Copy link
Member

@sisahoo sisahoo commented Jan 27, 2023

Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12257/head:pull/12257
$ git checkout pull/12257

Update a local copy of the PR:
$ git checkout pull/12257
$ git pull https://git.openjdk.org/jdk pull/12257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12257

View PR using the GUI difftool:
$ git pr show -t 12257

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12257.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2023

👋 Welcome back ssahoo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 27, 2023
@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@sisahoo The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jan 27, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@sisahoo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

  • 9952108: 8300811: jdb ThreadStartRequest and ThreadDeathRequest should use SUSPEND_NONE instead of SUSPEND_ALL
  • 24ff3da: 8301201: Allow \n@ inside inline tags using inlineContent
  • 3361a26: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3
  • bc750f7: 8294527: Some java.security.debug options missing from security docs
  • 7c6a8db: 8301447: [REDO] CodeHeap has virtual methods that are not overridden
  • cae577a: 8295486: Inconsistent constant field values observed during compilation
  • 969f6a3: 8301093: C2 fails assert(ctrl == kit.control()) failed: Control flow was added although the intrinsic bailed out
  • 2a8ae2f: 8300256: C2: vectorization is sometimes skipped on loops where it would succeed
  • ef0d0a7: 8301402: os::print_location gets is_global_handle assert
  • 4f6f3cc: 8301446: Remove unused includes of gc/shared/genOopClosures
  • ... and 70 more: https://git.openjdk.org/jdk/compare/e4252bb91478e9c2f0a5bbdae7cd663838d91b1b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 1, 2023
@sisahoo
Copy link
Member Author

sisahoo commented Feb 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 3, 2023

Going to push as commit 7f313b0.
Since your change was applied there have been 118 commits pushed to the master branch:

  • 3ad6aef: 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule
  • 4c9de87: 8301655: Problemlist jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java on Linux
  • 04278e6: 8301564: Non-C-heap allocated ResourceHashtable keys and values must have trivial destructor
  • b00b70c: 8286907: keytool should warn about weak PBE algorithms
  • ee0f5b5: 8301392: Port fdlibm log1p to Java
  • f696785: 8300869: Make use of the Double.toString(double) algorithm in java.util.Formatter
  • cf6b9eb: 8301637: ThreadLocalRandom.current().doubles().parallel() contention
  • c647ae6: 8301149: Parallel: Refactor MutableNUMASpace::update_layout
  • de57733: 8301644: com/sun/jdi/JdbStopThreadTest.java fails after JDK-8300811
  • 930ec00: 8301636: Minor cleanup in CommentHelper and DocPretty
  • ... and 108 more: https://git.openjdk.org/jdk/compare/e4252bb91478e9c2f0a5bbdae7cd663838d91b1b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 3, 2023
@openjdk openjdk bot closed this Feb 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 3, 2023
@openjdk
Copy link

openjdk bot commented Feb 3, 2023

@sisahoo Pushed as commit 7f313b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants