Skip to content

8301274: update for deprecated sprintf for security components#12265

Closed
XueleiFan wants to merge 1 commit intoopenjdk:masterfrom
XueleiFan:JDK-8301274
Closed

8301274: update for deprecated sprintf for security components#12265
XueleiFan wants to merge 1 commit intoopenjdk:masterfrom
XueleiFan:JDK-8301274

Conversation

@XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Jan 27, 2023

The sprintf is deprecated in Xcode 14 because of security concerns. The issue was addressed in JDK-8296812 for building failure, and JDK-8299378/JDK-8299635/JDK-8301132 for testing issues . This is a break-down update for sprintf uses in security components.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301274: update for deprecated sprintf for security components

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12265/head:pull/12265
$ git checkout pull/12265

Update a local copy of the PR:
$ git checkout pull/12265
$ git pull https://git.openjdk.org/jdk pull/12265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12265

View PR using the GUI difftool:
$ git pr show -t 12265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12265.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2023

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jan 27, 2023
@XueleiFan XueleiFan marked this pull request as ready for review January 27, 2023 20:41
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 27, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2023

Webrevs

@XueleiFan
Copy link
Member Author

ping ...

Copy link
Contributor

@ascarpino ascarpino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me

@openjdk
Copy link

openjdk bot commented Feb 13, 2023

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301274: update for deprecated sprintf for security components

Reviewed-by: ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 246 new commits pushed to the master branch:

  • d503c66: 8302155: [AIX] NUM_LCPU is not required variable
  • c37e9d1: 8298293: NMT: os::realloc() should verify that flags do not change between reallocations
  • 101db26: 8301697: [s390] Optimized-build is broken
  • f4d4fa5: 8300255: Introduce interface for GC oop verification in the assembler
  • 99b6c0e: 8302289: RISC-V: Use bgez instruction in arraycopy_simple_check when possible
  • 57aef85: 8301838: PPC: continuation yield intrinsic: exception check not needed if yield succeeded
  • df93880: 8301942: java/net/httpclient/DigestEchoClientSSL.java fail with -Xcomp
  • 0025764: 8040793: vmTestbase/nsk/monitoring/stress/lowmem fails on calling isCollectionUsageThresholdExceeded()
  • 1f9c110: 8301958: Reduce Arrays.copyOf/-Range overheads
  • cb81073: 8300139: [AIX] Use pthreads to avoid JNI_createVM call from primordial thread
  • ... and 236 more: https://git.openjdk.org/jdk/compare/9c4bc2c3954b97821a2bf371cab61edbc3d81d36...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 13, 2023
@XueleiFan XueleiFan closed this Feb 14, 2023
@XueleiFan XueleiFan deleted the JDK-8301274 branch February 14, 2023 15:36
@XueleiFan XueleiFan restored the JDK-8301274 branch February 14, 2023 15:37
@XueleiFan
Copy link
Member Author

/integrate

@XueleiFan XueleiFan reopened this Feb 14, 2023
@openjdk
Copy link

openjdk bot commented Feb 14, 2023

Going to push as commit f7dee77.
Since your change was applied there have been 262 commits pushed to the master branch:

  • ec901f2: 8301279: update for deprecated sprintf for management components
  • 8933c2d: 8298278: JFR: Turn MEMFLAGS into a type for use with the NativeMemoryUsage events
  • 77519e5: 8302354: InstanceKlass init state/thread should be atomic
  • 2ef001e: 8207017: Type annotations on anonymous classes in initializer blocks not written to class file
  • 8c2c8b3: 8295344: Harden runtime/StackGuardPages/TestStackGuardPages.java
  • 6d4b02b: 8302324: Inheritance tree does not show correct type parameters/arguments
  • 7dfe75c: 8301842: JFR: increase checkpoint event size for stacktrace and string pool
  • 66742c8: 8302368: [ZGC] Client build fails after JDK-8300255
  • 7c50ab1: 8225409: G1: Remove the Hot Card Cache
  • 92474f1: 8301243: java/net/httpclient/http2/IdleConnectionTimeoutTest.java intermittent failure
  • ... and 252 more: https://git.openjdk.org/jdk/compare/9c4bc2c3954b97821a2bf371cab61edbc3d81d36...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 14, 2023
@openjdk openjdk bot closed this Feb 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 14, 2023
@openjdk
Copy link

openjdk bot commented Feb 14, 2023

@XueleiFan Pushed as commit f7dee77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8301274 branch February 14, 2023 15:38
@openjdk
Copy link

openjdk bot commented Feb 14, 2023

@XueleiFan The command integrate can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants