8301342: Prefer ArrayList to LinkedList in LayoutComparator

[turbanoff]

There is only add/iterator calls on this list. No removes from the head or something like this. Not sure why LinkedList was used, but ArrayList should be preferred as more efficient and widely used (more chances for JIT) collection

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301342: Prefer ArrayList to LinkedList in LayoutComparator

Reviewers

• @SWinxy (no known github.com user name / role)
• Phil Race (@prrace - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12274/head:pull/12274
$ git checkout pull/12274

Update a local copy of the PR:
$ git checkout pull/12274
$ git pull https://git.openjdk.org/jdk pull/12274/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12274

View PR using the GUI difftool:
$ git pr show -t 12274

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12274.diff

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[SWinxy]

Personal preference is that the variables are typed as List<T> xyz = new ArrayList<>();.

[mlbridge]

Webrevs

• 00: Full (c1210e13)

[prrace]

This looks safe but I rather doubt anyone will be able to measure or ever see any performance benefit.
I suggest some manual testing of focus traversal which seems to be the sole user of the containing class.

[prrace]

I expect some testing to be done before it is pushed.

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301342: Prefer ArrayList to LinkedList in LayoutComparator

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 115 new commits pushed to the master branch:

• 3449324: 8301396: Port fdlibm expm1 to Java
• 3be5317: 8301798: [BACKOUT] jdb ThreadStartRequest and ThreadDeathRequest should use SUSPEND_NONE instead of SUSPEND_ALL
• e7247b1: 8298872: Update CheckStatus.java for changes to TLS implementation
• 20579e4: 8299994: java/security/Policy/Root/Root.java fails when home directory is read-only
• 5962226: 8300891: Deprecate for removal javax.swing.plaf.synth.SynthLookAndFeel.load(URL url)
• 8b70256: 8301787: java/net/httpclient/SpecialHeadersTest failing after JDK-8301306
• bccd55b: 8300295: [AIX] TestDaemonDestroy fails due to !is_primordial_thread assertion
• 7435b27: 8301744: Remove unused includes of genOopClosures.hpp
• 6f9106e: 8301306: java/net/httpclient/* fail with -Xcomp
• ac9e046: 8301479: Replace NULL with nullptr in os/linux
• ... and 105 more: https://git.openjdk.org/jdk/compare/af564e46b006fcd57ec7391cd1438b3b9311b1d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[turbanoff]

/integrate

[openjdk]

Going to push as commit d67bfe2.
Since your change was applied there have been 115 commits pushed to the master branch:

• 3449324: 8301396: Port fdlibm expm1 to Java
• 3be5317: 8301798: [BACKOUT] jdb ThreadStartRequest and ThreadDeathRequest should use SUSPEND_NONE instead of SUSPEND_ALL
• e7247b1: 8298872: Update CheckStatus.java for changes to TLS implementation
• 20579e4: 8299994: java/security/Policy/Root/Root.java fails when home directory is read-only
• 5962226: 8300891: Deprecate for removal javax.swing.plaf.synth.SynthLookAndFeel.load(URL url)
• 8b70256: 8301787: java/net/httpclient/SpecialHeadersTest failing after JDK-8301306
• bccd55b: 8300295: [AIX] TestDaemonDestroy fails due to !is_primordial_thread assertion
• 7435b27: 8301744: Remove unused includes of genOopClosures.hpp
• 6f9106e: 8301306: java/net/httpclient/* fail with -Xcomp
• ac9e046: 8301479: Replace NULL with nullptr in os/linux
• ... and 105 more: https://git.openjdk.org/jdk/compare/af564e46b006fcd57ec7391cd1438b3b9311b1d6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit d67bfe2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.