8293519: deprecation warnings should be emitted for uses of annotation methods inside other annotations

[vicente-romero-oracle]

Javac is forgetting to double check if the left hand side in an annotation name-value pair is a deprecated method, basically in this case:

@interface Anno {
    @Deprecated
    boolean b() default false;
}

@Anno(b = true) // a warning should be issued here
class Foo {}

this PR is fixing this oversight,

TIA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293519: deprecation warnings should be emitted for uses of annotation methods inside other annotations

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12280/head:pull/12280
$ git checkout pull/12280

Update a local copy of the PR:
$ git checkout pull/12280
$ git pull https://git.openjdk.org/jdk pull/12280/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12280

View PR using the GUI difftool:
$ git pr show -t 12280

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12280.diff

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1b60fb57)

[lahodaj]

Seems sensible. Do we need a CSR for this?

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293519: deprecation warnings should be emitted for uses of annotation methods inside other annotations

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• 419409b: 8301337: Remove unused os::_polling_page
• d583767: 8301338: Identical branch conditions in CompileBroker::print_heapinfo
• 810c8a2: 8301170: perfMemory_windows.cpp add free_security_attr to early returns
• 33e653e: 8301448: [BACKOUT] CodeHeap has virtual methods that are not overridden
• cdb4ba9: 8301326: Optimize compiler/uncommontrap/TestDeoptOOM.java test
• 9cc0171: 8301153: RISC-V: pipeline class for several instructions is not set correctly
• 633e291: 8301067: RISC-V: better error message when reporting unsupported satp modes
• 4b0e259: 8301344: G1: Remove DirtyCardToOopClosure forward declaration in g1OopClosures.hpp
• 7b3919d: 8301346: Remove dead emit_entry_barrier_stub definition
• a6867a7: 8301378: CodeHeap has virtual methods that are not overridden
• ... and 29 more: https://git.openjdk.org/jdk/compare/6475501a01268f5c35a9bf30f4104ce7a40d8181...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vicente-romero-oracle]

Seems sensible. Do we need a CSR for this?

not sure, probably in the fence, programs compiled with -Werror could see new errors but not sure we should have a CSR for that. If we were generating more errors yes sure a CSR but for a new warning, not so sure TBH. If you think we do I will file one though.

[vicente-romero-oracle]

/integrate

[openjdk]

Going to push as commit 6beadbb.
Since your change was applied there have been 46 commits pushed to the master branch:

• 4bef233: 8301549: Fix comment about ClassCircularityError
• e1bf471: 8301555: Remove constantPoolCacheKlass friend
• 5744c91: 8297158: Suspicious collection method call in Types.isSameTypeVisitor
• e193a0b: 8295951: intermittent cmp_baseline task failures with CDS files
• 60c535d: 8301340: Make DirtyCardToOopClosure stack-allocated
• b76a52f: 8301076: Replace NULL with nullptr in share/prims/
• 90ec19e: 8301068: Replace NULL with nullptr in share/jvmci/
• 419409b: 8301337: Remove unused os::_polling_page
• d583767: 8301338: Identical branch conditions in CompileBroker::print_heapinfo
• 810c8a2: 8301170: perfMemory_windows.cpp add free_security_attr to early returns
• ... and 36 more: https://git.openjdk.org/jdk/compare/6475501a01268f5c35a9bf30f4104ce7a40d8181...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle Pushed as commit 6beadbb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.