8301337: Remove unused os::_polling_page

[robehn]

Hi, please consider removing the unused field _polling_page in os.

Built tested many platforms + t1.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301337: Remove unused os::_polling_page

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Doug Simon (@dougxc - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12287/head:pull/12287
$ git checkout pull/12287

Update a local copy of the PR:
$ git checkout pull/12287
$ git pull https://git.openjdk.org/jdk pull/12287/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12287

View PR using the GUI difftool:
$ git pr show -t 12287

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12287.diff

[bridgekeeper]

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robehn The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4682aa3d)

[robehn]

/label add hotspot-runtime
/label remove hotspot

[openjdk]

@robehn
The hotspot-runtime label was successfully added.

[openjdk]

@robehn
The hotspot label was successfully removed.

[coleenp]

Good + trivial, the SA doesn't refer to this data.

[openjdk]

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301337: Remove unused os::_polling_page

Reviewed-by: coleenp, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• a74ebd0: 8299325: java/net/httpclient/CancelRequestTest.java fails "test CancelRequestTest.testGetSendAsync("https://localhost:46509/https1/x/same/interrupt", true, true)"
• 041a12e: 8301255: Http2Connection may send too many GOAWAY frames
• 476f58a: 8298424: Remove redundant FOUND_CORES variable in build-performance.m4
• ebb84ad: 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler
• 61a5f11: 8301033: RISC-V: Handle special cases for MinI/MaxI nodes for Zbb
• 82df4a2: 8301148: Serial: Remove ContiguousSpace::reset_saved_mark
• c672ed1: 8301248: Less side effects in InstanceRefKlass::trace_reference_gc
• cee4bd3: 8301047: Clean up type unsafe uses of oop from compiler code
• 7fae3a1: 8301229: Clean up SuspendibleThreadSet::_suspend_all
• f50cda7: 8301217: Remove FilteringClosure
• ... and 2 more: https://git.openjdk.org/jdk/compare/cbefe1fd35a4ad59ec979bdaee519617efac9ecf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[robehn]

Also a thanks to @dougxc who found it.

[robehn]

Thanks!

/integrate

[openjdk]

Going to push as commit 419409b.
Since your change was applied there have been 32 commits pushed to the master branch:

• d583767: 8301338: Identical branch conditions in CompileBroker::print_heapinfo
• 810c8a2: 8301170: perfMemory_windows.cpp add free_security_attr to early returns
• 33e653e: 8301448: [BACKOUT] CodeHeap has virtual methods that are not overridden
• cdb4ba9: 8301326: Optimize compiler/uncommontrap/TestDeoptOOM.java test
• 9cc0171: 8301153: RISC-V: pipeline class for several instructions is not set correctly
• 633e291: 8301067: RISC-V: better error message when reporting unsupported satp modes
• 4b0e259: 8301344: G1: Remove DirtyCardToOopClosure forward declaration in g1OopClosures.hpp
• 7b3919d: 8301346: Remove dead emit_entry_barrier_stub definition
• a6867a7: 8301378: CodeHeap has virtual methods that are not overridden
• aa34924: 8300463: Build failure on Windows 32 after JDK-8296401
• ... and 22 more: https://git.openjdk.org/jdk/compare/cbefe1fd35a4ad59ec979bdaee519617efac9ecf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robehn Pushed as commit 419409b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.