8301340: Make DirtyCardToOopClosure stack-allocated

[albertnetymk]

Simple change from resource-allocated to stack-allocated for a closure.

Test: hotspot_gc

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301340: Make DirtyCardToOopClosure stack-allocated

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12291/head:pull/12291
$ git checkout pull/12291

Update a local copy of the PR:
$ git checkout pull/12291
$ git pull https://git.openjdk.org/jdk pull/12291/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12291

View PR using the GUI difftool:
$ git pr show -t 12291

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12291.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6786d1ef)

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301340: Make DirtyCardToOopClosure stack-allocated

Reviewed-by: stefank, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 90ec19e: 8301068: Replace NULL with nullptr in share/jvmci/
• 419409b: 8301337: Remove unused os::_polling_page
• d583767: 8301338: Identical branch conditions in CompileBroker::print_heapinfo
• 810c8a2: 8301170: perfMemory_windows.cpp add free_security_attr to early returns
• 33e653e: 8301448: [BACKOUT] CodeHeap has virtual methods that are not overridden
• cdb4ba9: 8301326: Optimize compiler/uncommontrap/TestDeoptOOM.java test
• 9cc0171: 8301153: RISC-V: pipeline class for several instructions is not set correctly
• 633e291: 8301067: RISC-V: better error message when reporting unsupported satp modes
• 4b0e259: 8301344: G1: Remove DirtyCardToOopClosure forward declaration in g1OopClosures.hpp
• 7b3919d: 8301346: Remove dead emit_entry_barrier_stub definition
• ... and 18 more: https://git.openjdk.org/jdk/compare/c672ed16f363d9c92ccefe2e64a96e0a60a49588...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 60c535d.
Since your change was applied there have been 29 commits pushed to the master branch:

• b76a52f: 8301076: Replace NULL with nullptr in share/prims/
• 90ec19e: 8301068: Replace NULL with nullptr in share/jvmci/
• 419409b: 8301337: Remove unused os::_polling_page
• d583767: 8301338: Identical branch conditions in CompileBroker::print_heapinfo
• 810c8a2: 8301170: perfMemory_windows.cpp add free_security_attr to early returns
• 33e653e: 8301448: [BACKOUT] CodeHeap has virtual methods that are not overridden
• cdb4ba9: 8301326: Optimize compiler/uncommontrap/TestDeoptOOM.java test
• 9cc0171: 8301153: RISC-V: pipeline class for several instructions is not set correctly
• 633e291: 8301067: RISC-V: better error message when reporting unsupported satp modes
• 4b0e259: 8301344: G1: Remove DirtyCardToOopClosure forward declaration in g1OopClosures.hpp
• ... and 19 more: https://git.openjdk.org/jdk/compare/c672ed16f363d9c92ccefe2e64a96e0a60a49588...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 60c535d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.