JDK-8301378: CodeHeap has virtual methods that are not overridden

[jcking]

Remove unused virtual specifiers on CodeHeap methods. Virtual dispatch is not free in C++ and usually incurs a vtable lookup unless the compiler can prove the type is final, which with the current setup is not feasible.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301378: CodeHeap has virtual methods that are not overridden

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12298/head:pull/12298
$ git checkout pull/12298

Update a local copy of the PR:
$ git checkout pull/12298
$ git pull https://git.openjdk.org/jdk pull/12298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12298

View PR using the GUI difftool:
$ git pr show -t 12298

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12298.diff

[bridgekeeper]

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jcking The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (143b4dda)

[dcubed-ojdk]

/label add hotspot-compiler

[openjdk]

@dcubed-ojdk
The hotspot-compiler label was successfully added.

[vnkozlov]

Good.
This is leftover from AOT to support multiply code heaps: aotCodeHeap.cpp#l875

[openjdk]

@jcking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301378: CodeHeap has virtual methods that are not overridden

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• aa34924: 8300463: Build failure on Windows 32 after JDK-8296401
• 622b659: 8262994: Refactor String.split to help method inlining
• 2d7690b: 8301207: (jdeps) Deprecate jdeps -profile option
• 561a25e: Merge
• ef6200c: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF
• 63bb2ce: 8301205: Port fdlibm log10 to Java
• b84f4c4: 8301267: Update of config.guess broke build on WSL
• a128a5d: 8300810: Get rid of unused JDI removeListener() methods

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jcking]

/integrate

[openjdk]

@jcking
Your change (at version 143b4dd) is now ready to be sponsored by a Committer.

[TobiHartmann]

Looks good.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit a6867a7.
Since your change was applied there have been 8 commits pushed to the master branch:

• aa34924: 8300463: Build failure on Windows 32 after JDK-8296401
• 622b659: 8262994: Refactor String.split to help method inlining
• 2d7690b: 8301207: (jdeps) Deprecate jdeps -profile option
• 561a25e: Merge
• ef6200c: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF
• 63bb2ce: 8301205: Port fdlibm log10 to Java
• b84f4c4: 8301267: Update of config.guess broke build on WSL
• a128a5d: 8300810: Get rid of unused JDI removeListener() methods

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @jcking Pushed as commit a6867a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[TobiHartmann]

Unfortunately, this caused massive failures with the SA tests and we therefore had to back the change out (see JDK-8301448). @jcking please enable testing via Github actions, see https://openjdk.org/guide/#github-actions.

[jcking]

Unfortunately, this caused massive failures with the SA tests and we therefore had to back the change out (see JDK-8301448). @jcking please enable testing via Github actions, see https://openjdk.org/guide/#github-actions.

Sorry about that. It was such a trivial change I just assumed probably wasn't me. Then I remembered vmStructs exists once the failure was mentioned and face palmed.