Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256401: ZGC: Improve ZList verification #1230

Closed
wants to merge 2 commits into from

Conversation

pliden
Copy link
Contributor

@pliden pliden commented Nov 16, 2020

The ZList verification is currently fairly weak. I propose that we make the verification stronger to easier detect corrupt lists and misuse of list nodes. This patch also removes the unused ZList::transfer() function.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1230/head:pull/1230
$ git checkout pull/1230

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 16, 2020

👋 Welcome back pliden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2020

@pliden The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 16, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 16, 2020

Webrevs

@pliden pliden force-pushed the 8256401_zlist_verification branch from c729495 to 20a9314 Compare Nov 16, 2020
Copy link
Member

@albertnetymk albertnetymk left a comment

Only a minor comment; the rest look fine.

src/hotspot/share/gc/z/zList.inline.hpp Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2020

@pliden This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256401: ZGC: Improve ZList verification

Reviewed-by: ayang, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 17, 2020
@pliden
Copy link
Contributor Author

@pliden pliden commented Nov 17, 2020

Thanks for reviewing!

/integrate

@openjdk openjdk bot closed this Nov 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2020

@pliden Since your change was applied there have been 31 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 9130ca4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk-notifier bot referenced this issue Nov 17, 2020
Reviewed-by: ayang, stefank
@pliden pliden deleted the 8256401_zlist_verification branch Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants