8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread

[varada1110]

1. test/jdk/jni/nullCaller/NullCallerTest.java

2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java

3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java

   The above tests were blocked on AIX [@require os.family != "aix"] because these tests are failing to call JNI_CreateJavaVM. This is solved by implementing JNI_CreateJavaVM call via POSIX threads.
   Similarly there are tests which are not blocked and still failing to call JNI_CreateJavaVM on AIX :

4. test/hotspot/jtreg/runtime/jni/daemonDestroy/TestDaemonDestroy.java { PR : 12006 }

5. test/lib-test/jdk/test/lib/process/TestNativeProcessBuilder.java

The reported issue : 8300139

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300139: [AIX] Use pthreads to avoid JNI_createVM call from primordial thread

Reviewers

• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 52fa720a
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12302/head:pull/12302
$ git checkout pull/12302

Update a local copy of the PR:
$ git checkout pull/12302
$ git pull https://git.openjdk.org/jdk pull/12302/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12302

View PR using the GUI difftool:
$ git pr show -t 12302

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12302.diff

[bridgekeeper]

👋 Welcome back varada1110! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@varada1110 The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (32614a2c)
• 02: Full - Incremental (87e6cfba)
• 01: Full - Incremental (d106745e)
• 00: Full (52fa720a)

[dholmes-ora]

I hate to see the code duplication, but we don't have a sharing mechanism for the native parts of tests so that can't be helped.

Changes look good.

Please update the Oracle copyright lines so that the second year is 2023 if needed. Thanks.

[openjdk]

@varada1110 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300139: [AIX] Use pthreads to avoid JNI_createVM call from primordial thread

Reviewed-by: dholmes, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 210 new commits pushed to the master branch:

• d1c87a0: 8302203: IR framework should detect non-compilable test methods early
• 1fec6b5: 8301852: RISC-V: Optimize class atomic when order is memory_order_relaxed
• 7c233bc: 8302114: RISC-V: Several foreign jtreg tests fail with debug build after JDK-8301818
• 8049e59: 8301833: Add wide-ranging tests for FDLIBM porting
• 6a44120: 8301269: Update Commons BCEL to Version 6.7.0
• 6f9f2b5: 8301737: java/rmi/server/UnicastRemoteObject/serialFilter/FilterUROTest.java fail with -Xcomp
• 1ef9f65: 8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline
• 74b167b: 8301819: Enable continuations code by default
• 919a6da: 8301202: Port fdlibm log to Java
• 98e98e9: 8296322: javac: use methods to manage parser mode flags
• ... and 200 more: https://git.openjdk.org/jdk/compare/c672ed16f363d9c92ccefe2e64a96e0a60a49588...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @tstuefe) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[varada1110]

I hate to see the code duplication, but we don't have a sharing mechanism for the native parts of tests so that can't be helped.

Changes look good.

Please update the Oracle copyright lines so that the second year is 2023 if needed. Thanks.

Thanks @dholmes-ora . I will update Oracle copyright lines.

[tstuefe]

I hate to see the code duplication, but we don't have a sharing mechanism for the native parts of tests so that can't be helped.

It may be interesting to invest some time to find out if the "don't start on primordial thread" rule still holds on modern AIX versions.

I added this rule 18 years ago with our original (internal) AIX port because - IIRC - we were unable to find out the stack dimensions of the primordial thread, and we could not place guard pages reliably. And maybe some other problems too; the primordial thread behaved a lot different from pthread back then.

Maybe modern AIX variants don't have that problem anymore. We could cut down all this coding.

Cheers, Thomas

[dholmes-ora]

It just occurred to me that we may also need to update the test makefiles to link to libpthread for these modified tests?

[varada1110]

It just occurred to me that we may also need to update the test makefiles to link to libpthread for these modified tests?

Running test 'jtreg:test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java'
Passed: runtime/jni/CalleeSavedRegisters/FPRegs.java
Test results: passed: 1

Running test 'jtreg:test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java'
Passed: java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
Test results: passed: 1

Running test 'jtreg:test/jdk/jni/nullCaller/NullCallerTest.java'
Passed: jni/nullCaller/NullCallerTest.java
Test results: passed: 1

Running test 'jtreg:test/lib-test/jdk/test/lib/process/TestNativeProcessBuilder.java'
Passed: jdk/test/lib/process/TestNativeProcessBuilder.java
Test results: passed: 1

These tests is passing without adding lpthread in JtregNativeHotspot.gmk. Do I need to update the makefile?

[tstuefe]

Small nits remain, nothing major.

[tstuefe]

Looks good to me. Thanks.

[dholmes-ora]

These tests is passing without adding lpthread in JtregNativeHotspot.gmk. Do I need to update the makefile?

I'm somewhat surprised that the tests pass without explicit linkage, but perhaps libpthread is a default on AIX. If things are working in your AIX testing then that is fine.

[varada1110]

/integrate

[openjdk]

@varada1110
Your change (at version 32614a2) is now ready to be sponsored by a Committer.

[tstuefe]

/sponsor

[openjdk]

Going to push as commit cb81073.
Since your change was applied there have been 215 commits pushed to the master branch:

• bbd8ae7: 8294194: [AArch64] Create intrinsics compress and expand
• 4e327db: 8301499: Replace NULL with nullptr in cpu/zero
• 0458d38: 6513512: MetalLookAndFeel.initClassDefaults does not install an entry for MetalMenuBarUI
• f4b140b: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
• 5d39d14: 8299970: Speed up compiler/arraycopy/TestArrayCopyConjoint.java
• d1c87a0: 8302203: IR framework should detect non-compilable test methods early
• 1fec6b5: 8301852: RISC-V: Optimize class atomic when order is memory_order_relaxed
• 7c233bc: 8302114: RISC-V: Several foreign jtreg tests fail with debug build after JDK-8301818
• 8049e59: 8301833: Add wide-ranging tests for FDLIBM porting
• 6a44120: 8301269: Update Commons BCEL to Version 6.7.0
• ... and 205 more: https://git.openjdk.org/jdk/compare/c672ed16f363d9c92ccefe2e64a96e0a60a49588...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe @varada1110 Pushed as commit cb81073.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.