8301465: Remove unnecessary nmethod arming in Full GC of Serial/Parallel

[albertnetymk]

Simple removing unnecessary code and adding API documentation.

Test: hotspot_gc

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301465: Remove unnecessary nmethod arming in Full GC of Serial/Parallel

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12311/head:pull/12311
$ git checkout pull/12311

Update a local copy of the PR:
$ git checkout pull/12311
$ git pull https://git.openjdk.org/jdk pull/12311/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12311

View PR using the GUI difftool:
$ git pr show -t 12311

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12311.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c78f41b6)
• 00: Full (49ac215a)

[tschatzl]

I would prefer to have general documentation and usage information about a method in the .hpp file.

[albertnetymk]

Moved.

[tschatzl]

Lgtm.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301465: Remove unnecessary nmethod arming in Full GC of Serial/Parallel

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 91 new commits pushed to the master branch:

• 8f195ff: 8298952: All nodes should have type(n) == Value(n) after IGVN
• e88fd8c: 8301768: G1: Remove unimplemented HeapRegionRemSet::split_card
• 96c50a3: 8301752: [IR Framework] Add more IR framework examples
• 3646c4e: 8301171: Rename sanitizers/address.h to sanitizers/address.hpp
• 3f3356b: 8301760: Fix possible leak in SpNegoContext dispose
• b4cb6c8: 8301743: RISC-V: Add InlineSkippedInstructionsCounter to post-call nops
• 4dd6e8f: 8301740: RISC-V: Address::uses() should check address mode
• 8507db1: 8301628: RISC-V: c2 fix pipeline class for several instructions
• d67bfe2: 8301342: Prefer ArrayList to LinkedList in LayoutComparator
• 3449324: 8301396: Port fdlibm expm1 to Java
• ... and 81 more: https://git.openjdk.org/jdk/compare/4b0e259d1651c2131031e581fdc0482858325081...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 371a0c4.
Since your change was applied there have been 93 commits pushed to the master branch:

• 716f1df: 8301478: Replace NULL with nullptr in os/bsd
• ab528ce: 4934362: see also refers to self
• 8f195ff: 8298952: All nodes should have type(n) == Value(n) after IGVN
• e88fd8c: 8301768: G1: Remove unimplemented HeapRegionRemSet::split_card
• 96c50a3: 8301752: [IR Framework] Add more IR framework examples
• 3646c4e: 8301171: Rename sanitizers/address.h to sanitizers/address.hpp
• 3f3356b: 8301760: Fix possible leak in SpNegoContext dispose
• b4cb6c8: 8301743: RISC-V: Add InlineSkippedInstructionsCounter to post-call nops
• 4dd6e8f: 8301740: RISC-V: Address::uses() should check address mode
• 8507db1: 8301628: RISC-V: c2 fix pipeline class for several instructions
• ... and 83 more: https://git.openjdk.org/jdk/compare/4b0e259d1651c2131031e581fdc0482858325081...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 371a0c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.