Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8300098 : java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3 #12318

Closed
wants to merge 1 commit into from

Conversation

viktorklang-ora
Copy link
Contributor

@viktorklang-ora viktorklang-ora commented Jan 31, 2023

The proposed fix by @DougLea ensures that the state transition into waiting is retried in the cases where a previous waiter isn't making progress and a new waiter goes into waiting.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3

Contributors

  • Doug Lea <dl@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12318/head:pull/12318
$ git checkout pull/12318

Update a local copy of the PR:
$ git checkout pull/12318
$ git pull https://git.openjdk.org/jdk pull/12318/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12318

View PR using the GUI difftool:
$ git pr show -t 12318

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12318.diff

…iateTest.java fails with internal timeout when executed with TieredCompilation1/3
@viktorklang-ora
Copy link
Contributor Author

/contributor add @DougLea

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2023

👋 Welcome back viktorklang-ora! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 31, 2023

@viktorklang-ora
Contributor Doug Lea <dl@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Jan 31, 2023

@viktorklang-ora The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 31, 2023
@viktorklang-ora viktorklang-ora changed the title JDK-83000098 : java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3 JDK-8300098 : java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3 Jan 31, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 31, 2023
@viktorklang-ora viktorklang-ora deleted the 83000098 branch January 31, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
1 participant