Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8300098 : java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3 #12319

Closed
wants to merge 1 commit into from

Conversation

viktorklang-ora
Copy link
Contributor

@viktorklang-ora viktorklang-ora commented Jan 31, 2023

The proposed fix by @DougLea ensures that the state transition into waiting is retried in the cases where a previous waiter isn't making progress and a new waiter goes into waiting.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3

Reviewers

Contributors

  • Doug Lea <dl@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12319/head:pull/12319
$ git checkout pull/12319

Update a local copy of the PR:
$ git checkout pull/12319
$ git pull https://git.openjdk.org/jdk pull/12319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12319

View PR using the GUI difftool:
$ git pr show -t 12319

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12319.diff

…ateTest.java fails with internal timeout when executed with TieredCompilation1/3
@viktorklang-ora
Copy link
Contributor Author

/contributor add @DougLea

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2023

👋 Welcome back viktorklang-ora! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 31, 2023
@openjdk
Copy link

openjdk bot commented Jan 31, 2023

@viktorklang-ora
Contributor Doug Lea <dl@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Jan 31, 2023

@viktorklang-ora The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 31, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2023

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Viktor, I don't have enough knowledge of this area, but looking at this change and going by what Doug noted in the JBS issue:

There's a CHM bug scenario that I haven't been able to rule out after looking at this again: A late clearing of waiter field in ConcurrentHashMap.contendedLock by a previous waiter. There may be a constraint I've forgotten that makes this impossible in principle, but it is easy to change to be more clearly correct by replacing the writes with CASes

this change looks OK to me.

You might have to add a noreg-hard label to that JBS issue.

@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3

Co-authored-by: Doug Lea <dl@openjdk.org>
Reviewed-by: jpai, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 115 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran, @AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 1, 2023
@viktorklang-ora
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 6, 2023
@openjdk
Copy link

openjdk bot commented Feb 6, 2023

@viktorklang-ora
Your change (at version d132973) is now ready to be sponsored by a Committer.

@AlanBateman
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 6, 2023

Going to push as commit ecf8842.
Since your change was applied there have been 115 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 6, 2023
@openjdk openjdk bot closed this Feb 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 6, 2023
@openjdk
Copy link

openjdk bot commented Feb 6, 2023

@AlanBateman @viktorklang-ora Pushed as commit ecf8842.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants