JDK-8300909: Update com/sun/jndi/dns/Test6991580.java manual test instruction

[bwhuang-us]

Test failed for exception in thread "main" java.lang.IllegalAccessError: class IPv6NameserverPlatformParsingTest (in unnamed module @0x72a8ab1a) cannot access class com.sun.jndi.dns.DnsContextFactory (in module jdk.naming.dns) because module jdk.naming.dns does not export com.sun.jndi.dns to unnamed module @0x72a8ab1a
at IPv6NameserverPlatformParsingTest.main(IPv6NameserverPlatformParsingTest.java:46)

This task is created to update test instruction to include --add-modules and --add-opens jvm parameters to java command.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300909: Update com/sun/jndi/dns/Test6991580.java manual test instruction

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12351/head:pull/12351
$ git checkout pull/12351

Update a local copy of the PR:
$ git checkout pull/12351
$ git pull https://git.openjdk.org/jdk pull/12351/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12351

View PR using the GUI difftool:
$ git pr show -t 12351

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12351.diff

[bridgekeeper]

👋 Welcome back bhuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bwhuang-us The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (d271f3ba)
• 00: Full (d274657f)

[AlanBateman]

I don't think you'll need the --add-modules in the instructions. The java.desktop exports as an API so it will be resolved by default, same for the java.naming and that will ensure that the JNDI service provider modules are resolved.

[bwhuang-us]

Thank you for the feedback. I will remove the --add-modules.

[AlanBateman]

Looks fine, I assume you've update the copyright header before you integrate.

[openjdk]

@bwhuang-us This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300909: Update com/sun/jndi/dns/Test6991580.java manual test instruction

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 6beadbb: 8293519: deprecation warnings should be emitted for uses of annotation methods inside other annotations
• 4bef233: 8301549: Fix comment about ClassCircularityError
• e1bf471: 8301555: Remove constantPoolCacheKlass friend

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

Going to push as commit 09bfbf8.
Since your change was applied there have been 3 commits pushed to the master branch:

• 6beadbb: 8293519: deprecation warnings should be emitted for uses of annotation methods inside other annotations
• 4bef233: 8301549: Fix comment about ClassCircularityError
• e1bf471: 8301555: Remove constantPoolCacheKlass friend

Your commit was automatically rebased without conflicts.

[openjdk]

@bwhuang-us Pushed as commit 09bfbf8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.