JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only

[bwhuang-us]

Root.java is changed to a manual test because it requires test to be run with the root user privilege, and it requires to modify the user policy file in the home director.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only

Reviewers

• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12354/head:pull/12354
$ git checkout pull/12354

Update a local copy of the PR:
$ git checkout pull/12354
$ git pull https://git.openjdk.org/jdk pull/12354/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12354

View PR using the GUI difftool:
$ git pr show -t 12354

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12354.diff

[bridgekeeper]

👋 Welcome back bhuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bwhuang-us The following labels will be automatically applied to this pull request:

• core-libs
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (b8883211)
• 03: Full - Incremental (49848a01)
• 02: Full - Incremental (3b736036)
• 01: Full - Incremental (60096f09)
• 00: Full (69a7a490)

[rhalade]

Can you print set of instructions to run test as root? Also it will help if test fails when not run as root to begin with.

[openjdk]

@bwhuang-us This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299994: java/security/Policy/Root/Root.java fails when home directory is read-only

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

• 5962226: 8300891: Deprecate for removal javax.swing.plaf.synth.SynthLookAndFeel.load(URL url)
• 8b70256: 8301787: java/net/httpclient/SpecialHeadersTest failing after JDK-8301306
• bccd55b: 8300295: [AIX] TestDaemonDestroy fails due to !is_primordial_thread assertion
• 7435b27: 8301744: Remove unused includes of genOopClosures.hpp
• 6f9106e: 8301306: java/net/httpclient/* fail with -Xcomp
• ac9e046: 8301479: Replace NULL with nullptr in os/linux
• cf68d9f: 8299155: C2: SubTypeCheckNode::verify() should not produce dependencies / oop pool entries
• 11804b2: 8301050: Detect Xen Virtualization on Linux aarch64
• b504c94: 8300235: Use VarHandle access in Image(Input | Output)StreamImpl classes
• 406021a: 8300929: Avoid unnecessary array fill after creation in java.awt.image
• ... and 53 more: https://git.openjdk.org/jdk/compare/6beadbbe9f0721fbdfc48e6f2c14aa6dab982be0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bwhuang-us]

/integrate

[openjdk]

Going to push as commit 20579e4.
Since your change was applied there have been 63 commits pushed to the master branch:

• 5962226: 8300891: Deprecate for removal javax.swing.plaf.synth.SynthLookAndFeel.load(URL url)
• 8b70256: 8301787: java/net/httpclient/SpecialHeadersTest failing after JDK-8301306
• bccd55b: 8300295: [AIX] TestDaemonDestroy fails due to !is_primordial_thread assertion
• 7435b27: 8301744: Remove unused includes of genOopClosures.hpp
• 6f9106e: 8301306: java/net/httpclient/* fail with -Xcomp
• ac9e046: 8301479: Replace NULL with nullptr in os/linux
• cf68d9f: 8299155: C2: SubTypeCheckNode::verify() should not produce dependencies / oop pool entries
• 11804b2: 8301050: Detect Xen Virtualization on Linux aarch64
• b504c94: 8300235: Use VarHandle access in Image(Input | Output)StreamImpl classes
• 406021a: 8300929: Avoid unnecessary array fill after creation in java.awt.image
• ... and 53 more: https://git.openjdk.org/jdk/compare/6beadbbe9f0721fbdfc48e6f2c14aa6dab982be0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bwhuang-us Pushed as commit 20579e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.