Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245654: Add Certigna Root CA #12376

Closed
wants to merge 12 commits into from
Closed

8245654: Add Certigna Root CA #12376

wants to merge 12 commits into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Feb 1, 2023

This fix adds Certigna root CA to cacerts trust store.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12376/head:pull/12376
$ git checkout pull/12376

Update a local copy of the PR:
$ git checkout pull/12376
$ git pull https://git.openjdk.org/jdk pull/12376/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12376

View PR using the GUI difftool:
$ git pr show -t 12376

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12376.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2023

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 1, 2023
@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Feb 1, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 6, 2023

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8245654: Add Certigna Root CA

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 267 new commits pushed to the master branch:

  • d53ade1: 8301813: Bad caret position in error message
  • 8c01b6e: 8221580: Confusing diagnostic for assigning a static final field in a constructor
  • c129ce4: 8300259: Add test coverage for processing of pending block files in signed JARs
  • b569742: 8301788: AlgorithmId should keep lowercase characters from 3rd party providers
  • 05ea083: 8301167: Update VerifySignedJar to actually exercise and test verification
  • ecf8842: 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3
  • 7ae447f: 8301095: [s390x] TestDwarf.java fails
  • 9c80b8a: 8299683: [S390X] Problems with -XX:+VerifyStack
  • 8e9b726: 8301599: Serial: Refactor nested closures in DefNewGeneration
  • 7730506: 8299162: Refactor shared trampoline emission logic
  • ... and 257 more: https://git.openjdk.org/jdk/compare/facd41511b972e940ecab3bc57f5f23efca43343...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 6, 2023
@rhalade
Copy link
Member Author

rhalade commented Feb 9, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 9, 2023

Going to push as commit 8c87a67.
Since your change was applied there have been 325 commits pushed to the master branch:

  • 97d0c87: 8302109: Trivial fixes to btree tests
  • 0aeebee: 8301988: VerifyLiveClosure::verify_liveness asserts on bad pointers outside heap
  • 4815566: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes
  • 5147969: 8272288: Funky multiresolution image breaks graphics context
  • 77ead44: 8302066: Counter _number_of_nmethods_with_dependencies should be atomic.
  • f4b72df: 8282379: [LOOM] vmTestbase/nsk/jdi/ClassType/invokeMethod/invokemethod011 sometimes fails
  • 7fd440d: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation
  • 7901f45: 8301260: Add system property to toggle XML Signature secure validation mode
  • 597a9a4: 8301822: BasicLookAndFeel does not need to check for null after checking for type
  • 3b05a94: 8301858: Verification error when compiling switch with record patterns
  • ... and 315 more: https://git.openjdk.org/jdk/compare/facd41511b972e940ecab3bc57f5f23efca43343...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 9, 2023
@openjdk openjdk bot closed this Feb 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 9, 2023
@openjdk
Copy link

openjdk bot commented Feb 9, 2023

@rhalade Pushed as commit 8c87a67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the 8247698-certigna branch March 13, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants