Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301644: com/sun/jdi/JdbStopThreadTest.java fails after JDK-8300811 #12378

Closed

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Feb 1, 2023

This test started failing after JDK-8300811, which made the jdb ThreadStartRequest and ThreadDeathRequest use SUSPEND_NONE instead of SUSPEND_ALL. This sped up the handling of these events a lot, which has impacted the timing of this test and exposed a bug.

The 2nd (last) breakpoint this test sets up uses SUSPEND_NONE. The debuggee quickly exits after hitting the breakpoint because it is not suspended. This puts the test at risk of having the debuggee exit before jdb can produce the full output for the breakpoint that includes the line number information. The test is looking for this output When it is not there, the test fails. Although the risk was always there, it was made worse by speeding up the handling of the ThreadDeath event. This is why this issue is also only seen on product builds (jdb needs to be running fast).

This failure is somewhat noisy so I'd like to push it quickly, but it should still have two reviews.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301644: com/sun/jdi/JdbStopThreadTest.java fails after JDK-8300811

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12378/head:pull/12378
$ git checkout pull/12378

Update a local copy of the PR:
$ git checkout pull/12378
$ git pull https://git.openjdk.org/jdk pull/12378/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12378

View PR using the GUI difftool:
$ git pr show -t 12378

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12378.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2023

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8301644 8301644: com/sun/jdi/JdbStopThreadTest.java fails after JDK-8300811 Feb 1, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 1, 2023
@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Feb 1, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 2, 2023

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301644: com/sun/jdi/JdbStopThreadTest.java fails after JDK-8300811

Reviewed-by: amenkov, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 7b6ac41: 8286876: NMT.test_unaliged_block_address_vm_assert fails if using clang toolchain
  • d097b5e: 8301508: Replace NULL with nullptr in os_cpu/linux_s390
  • c8307e3: 8301500: Replace NULL with nullptr in os_cpu/aix_ppc
  • 218223e: 8301501: Replace NULL with nullptr in os_cpu/bsd_aarch64
  • b81f0ff: 8301505: Replace NULL with nullptr in os_cpu/linux_arm
  • 42a286a: 8301511: Replace NULL with nullptr in os_cpu/linux_zero
  • ad79e49: 8301512: Replace NULL with nullptr in os_cpu/windows_aarch64
  • 8cc399b: 8301503: Replace NULL with nullptr in os_cpu/bsd_zero
  • c109dae: 8301513: Replace NULL with nullptr in os_cpu/windows_x86
  • 182d1b2: 8301507: Replace NULL with nullptr in os_cpu/linux_riscv
  • ... and 9 more: https://git.openjdk.org/jdk/compare/960c3931337b314417ad33d8a775ee3e251692d7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 2, 2023
@plummercj
Copy link
Contributor Author

Thanks for the reviews Alex and Kevin!

/integrate

@openjdk
Copy link

openjdk bot commented Feb 2, 2023

Going to push as commit de57733.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 930ec00: 8301636: Minor cleanup in CommentHelper and DocPretty
  • 725d57b: 8301659: Resolve initialization reordering issues on Windows for libawt and libsaproc
  • 2d50c7d: 8298979: Remove duplicated serviceability/jvmti/thread/GetAllThreads/allthr01/allthr01.java
  • 59b7fb1: 8300273: [IR framework] Handle message instead of bailing out
  • 5b1584b: 8298880: VectorLogicalOpIdentityTest.java IR test incorrectly use avx3 instead of avx512
  • 21c1afb: 8301612: OopLoadProxy constructor should be explicit
  • 03b23a1: 8301367: Add exception handler method to the BaseLdapServer
  • 7b6ac41: 8286876: NMT.test_unaliged_block_address_vm_assert fails if using clang toolchain
  • d097b5e: 8301508: Replace NULL with nullptr in os_cpu/linux_s390
  • c8307e3: 8301500: Replace NULL with nullptr in os_cpu/aix_ppc
  • ... and 16 more: https://git.openjdk.org/jdk/compare/960c3931337b314417ad33d8a775ee3e251692d7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 2, 2023
@openjdk openjdk bot closed this Feb 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2023
@openjdk
Copy link

openjdk bot commented Feb 2, 2023

@plummercj Pushed as commit de57733.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants