8301380: jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java

[mgronlun]

Greetings,

please help review this small adjustment to close the gap where iterated threads that attach via jni are left without a valid JFR thread id. For details, please see the JIRA issue.

Testing: jdk_jfr

Thanks
Markus

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301380: jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Erik Gahlin (@egahlin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12388/head:pull/12388
$ git checkout pull/12388

Update a local copy of the PR:
$ git checkout pull/12388
$ git pull https://git.openjdk.org/jdk pull/12388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12388

View PR using the GUI difftool:
$ git pr show -t 12388

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12388.diff

[bridgekeeper]

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mgronlun The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (5f129b91)
• 01: Full - Incremental (34fc58aa)
• 00: Full (d3d42150)

[mgronlun]

/label add hotspot-jfr

[openjdk]

@mgronlun
The hotspot-jfr label was successfully added.

[dholmes-ora]

Code changes look good. A couple of suggested comment changes to explain the reasoning more clearly. Thanks.

[openjdk]

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301380: jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java

Reviewed-by: dholmes, egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

• 2712615: 8298445: Add LeakSanitizer support in HotSpot
• 2e2e71e: 8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones
• a73d012: 8295019: Cannot call a method with a parameter of a local class declared in a lambda
• 4fe99da: 8151413: os::allocation_granularity/page_size and friends return signed values
• 09b8a19: 8300177: URISyntaxException fields can be final
• c61a382: 8296646: com/sun/jdi/JdbLastErrorTest.java test failure
• f5f38a8: 8301371: Interpreter store barriers on x86_64 don't have disjoint temp registers
• 77dbcd8: 8301641: NativeMemoryUsageTotal event uses reserved value for committed field
• 1aaf394: 8301736: jdk/incubator/concurrent/StructuredTaskScope/StructuredTaskScopeTest.java fail with -Xcomp
• 9dad874: 8298413: [s390] CPUInfoTest fails due to uppercase feature string
• ... and 60 more: https://git.openjdk.org/jdk/compare/7b6ac41ab115f0fb715d32b19bec184ed53d0cd7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Marking this not ready while details are discussed.

[dholmes-ora]

Looks good.

Thanks

[mgronlun]

Thanks @dholmes-ora, for the review!

[mgronlun]

/integrate

[openjdk]

Going to push as commit c92a7de.
Since your change was applied there have been 77 commits pushed to the master branch:

• 0f08785: 8301756: Missed constructor from 8301659
• 4de2d3c: 8301862: G1: Remove G1PageBasedVirtualSpace::_executable
• e628fd5: 8301214: Adjust handshakeTimeout value in test HandshakeTimeout.java after 8189338
• ac7119f: 8280126: C2: detect and remove dead irreducible loops
• 2a579ab: 8292588: [macos] Multiscreen/MultiScreenLocationTest/MultiScreenLocationTest.java: Robot.mouseMove test failed on Screen #0
• 53f72ed: 8286510: Tests under dynamicArchive/methodHandles should check for loading of lambda proxy classes
• 74485a3: 8301810: Bug in doctree DocCommentTester.compress
• 2712615: 8298445: Add LeakSanitizer support in HotSpot
• 2e2e71e: 8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones
• a73d012: 8295019: Cannot call a method with a parameter of a local class declared in a lambda
• ... and 67 more: https://git.openjdk.org/jdk/compare/7b6ac41ab115f0fb715d32b19bec184ed53d0cd7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mgronlun Pushed as commit c92a7de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.