Skip to content

8301717: Remove obsolete jib profiles #12395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Feb 2, 2023

This patch removes some now obsolete jib profiles configurations.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12395/head:pull/12395
$ git checkout pull/12395

Update a local copy of the PR:
$ git checkout pull/12395
$ git pull https://git.openjdk.org/jdk pull/12395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12395

View PR using the GUI difftool:
$ git pr show -t 12395

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12395.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2023

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8301717 8301717: Remove obsolete jib profiles Feb 2, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 2, 2023
@openjdk
Copy link

openjdk bot commented Feb 2, 2023

@erikj79 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Feb 2, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2023

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal seems fine. Thanks.

@openjdk
Copy link

openjdk bot commented Feb 3, 2023

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301717: Remove obsolete jib profiles

Reviewed-by: dholmes, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

  • 09b8a19: 8300177: URISyntaxException fields can be final
  • c61a382: 8296646: com/sun/jdi/JdbLastErrorTest.java test failure
  • f5f38a8: 8301371: Interpreter store barriers on x86_64 don't have disjoint temp registers
  • 77dbcd8: 8301641: NativeMemoryUsageTotal event uses reserved value for committed field
  • 1aaf394: 8301736: jdk/incubator/concurrent/StructuredTaskScope/StructuredTaskScopeTest.java fail with -Xcomp
  • 9dad874: 8298413: [s390] CPUInfoTest fails due to uppercase feature string
  • 98433a2: 8296999: AArch64: scalar intrinsics for reverse method in Integer and Long
  • c04a982: 8301818: RISC-V: Factor out function mvw from MacroAssembler
  • 787e16b: 8289077: Add manual tests to open
  • 07fb4f9: 7167356: (javac) investigate failing tests in JavacParserTest
  • ... and 72 more: https://git.openjdk.org/jdk/compare/d6832121b718d40df263da6e2f9261dee2c4c508...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 3, 2023
@erikj79
Copy link
Member Author

erikj79 commented Feb 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 8, 2023

Going to push as commit 8a9e383.
Since your change was applied there have been 101 commits pushed to the master branch:

  • 631a279: 8301567: The test/jdk/java/awt/AppContext/ApplicationThreadsStop/java.policy is unused
  • 638d612: 8298478: (fs) Path.of should allow input to include long path prefix
  • 10dd98d: 8301462: Convert Permission files to use lambda after JDK-8076596
  • 8d4c76d: 8302072: Parallel: Remove unimplemented ParCompactionManager::stack_push
  • ecf21a9: 8301767: Convert virtual thread tests to JUnit
  • 9af2ea2: 8301828: Avoid unnecessary array fill after creation in javax.swing.text
  • 3db352d: 8302047: G1: Remove unused G1RegionToSpaceMapper::_region_granularity
  • c92a7de: 8301380: jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java
  • 0f08785: 8301756: Missed constructor from 8301659
  • 4de2d3c: 8301862: G1: Remove G1PageBasedVirtualSpace::_executable
  • ... and 91 more: https://git.openjdk.org/jdk/compare/d6832121b718d40df263da6e2f9261dee2c4c508...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 8, 2023
@openjdk openjdk bot closed this Feb 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 8, 2023
@openjdk
Copy link

openjdk bot commented Feb 8, 2023

@erikj79 Pushed as commit 8a9e383.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants