8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType

[datior]

The change fixes the regression introduced by https://bugs.openjdk.java.net/browse/JDK-8241080.

Method validateAssignment() in com.sun.tools.jdi.ObjectReferenceImpl now always retrieves the reference type and that requires one more JDWP packet if the value is not cached yet. Before https://bugs.openjdk.java.net/browse/JDK-8241080 this happened for arrays only.

Testing: tier1-tier3 tests passes.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Alex Menkov (@alexmenkov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/124/head:pull/124
$ git checkout pull/124

[bridgekeeper]

👋 Welcome back dtitov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@datior The following label will be automatically applied to this pull request: serviceability.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 00: Full (0a0b2a4)

[plummercj]

The changes look good to me. Can I ask how you noticed the extra unnecessary JDWP packet?

[openjdk]

@datior This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType

Reviewed-by: cjplummer, amenkov

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 36 commits pushed to the master branch:

• 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
• b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
• d219d8b: 8253002: Remove the unused SafePointNode::_oop_map field
• dafcf10: 8027545: Improve object array chunking test in G1's copy_to_survivor_space
• 7eb4d4a: 8247909: Improve PrimitiveConversions::cast using C++14
• fa30241: 8249676: [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
• 9ea43a9: 8253148: Fix terminology in align_down comment
• 3f455f0: 8253089: Windows (MSVC 2017) build fails after JDK-8243208
• af8c678: 8247910: Improve alignment and power-of-2 utilities using C++14
• 70cc7fc: 8253098: Archived full module graph should be disabled if CDS heap cannot be mapped
• ... and 26 more: https://git.openjdk.java.net/jdk/compare/44a74dac957ca7cc10eaddafb6bd32b74a8d84c8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 74851c507bed9eb2e1e0b0eac3b53a74decb2588.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[datior]

Thanks @plummercj for the review. The issue with an extra JDWP packet was reported in serviceability-dev mail list : https://mail.openjdk.java.net/pipermail/serviceability-dev/2020-September/032960.html .

[sspitsyn]

Hi Daniil, it looks good.

[datior]

/integrate

[openjdk]

@datior Since your change was applied there have been 36 commits pushed to the master branch:

• 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
• b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
• d219d8b: 8253002: Remove the unused SafePointNode::_oop_map field
• dafcf10: 8027545: Improve object array chunking test in G1's copy_to_survivor_space
• 7eb4d4a: 8247909: Improve PrimitiveConversions::cast using C++14
• fa30241: 8249676: [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
• 9ea43a9: 8253148: Fix terminology in align_down comment
• 3f455f0: 8253089: Windows (MSVC 2017) build fails after JDK-8243208
• af8c678: 8247910: Improve alignment and power-of-2 utilities using C++14
• 70cc7fc: 8253098: Archived full module graph should be disabled if CDS heap cannot be mapped
• ... and 26 more: https://git.openjdk.java.net/jdk/compare/44a74dac957ca7cc10eaddafb6bd32b74a8d84c8...master

Your commit was automatically rebased without conflicts.

Pushed as commit 65d6c10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.