8301787: java/net/httpclient/SpecialHeadersTest failing after JDK-8301306

[dfuch]

Please find here a changeset that reverts a recent change made to java/net/httpclient/SpecialHeadersTest.java. That change is causing the test to fail in the CI with:

test result: Error. Parse Exception: Invalid tag: requests

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301787: java/net/httpclient/SpecialHeadersTest failing after JDK-8301306

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer) ⚠️ Review applies to 52eb9055
• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12409/head:pull/12409
$ git checkout pull/12409

Update a local copy of the PR:
$ git checkout pull/12409
$ git pull https://git.openjdk.org/jdk pull/12409/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12409

View PR using the GUI difftool:
$ git pr show -t 12409

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12409.diff

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (605faad0)
• 00: Full (52eb9055)

[dcubed-ojdk]

I think that was supposed to be @requires, but I'm good with removing
the change for proper testing by the original submitter.

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301787: java/net/httpclient/SpecialHeadersTest failing after JDK-8301306

Reviewed-by: dcubed, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• bccd55b: 8300295: [AIX] TestDaemonDestroy fails due to !is_primordial_thread assertion

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dfuch]

I think that was supposed to be @requires, but I'm good with removing the change for proper testing by the original submitter.

Ah good point. I could not find an example of test using vm.compMode != "Xcomp" that's why I opted for simply removing the line.

[dfuch]

I think that was supposed to be @requires, but I'm good with removing the change for proper testing by the original submitter.

Ah good point. I could not find an example of test using vm.compMode != "Xcomp" that's why I opted for simply removing the line.

OK - my regexp was bad - I have updated the test to use @requires. can you re-review @dcubed-ojdk ?

[dfuch]

/integrate

[openjdk]

Going to push as commit 8b70256.
Since your change was applied there has been 1 commit pushed to the master branch:

• bccd55b: 8300295: [AIX] TestDaemonDestroy fails due to !is_primordial_thread assertion

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch Pushed as commit 8b70256.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.